← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1714348] Re: pecan is missing some body validation logic from legacy API

 

Reviewed:  https://review.openstack.org/499427
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=444f802012d30d912f300ad05cdf201b8c48f347
Submitter: Jenkins
Branch:    master

commit 444f802012d30d912f300ad05cdf201b8c48f347
Author: Kevin Benton <kevin@xxxxxxxxxx>
Date:   Wed Aug 30 19:59:50 2017 -0700

    Pecan: Add missing body validations
    
    This changes the pecan body validation to bring parity with the
    old legacy controller code.
    
    * If a body is present on POST/PUT, it must be a JSON dict
    * DELETEs to an item must not contain a body
    * A POST request to the standard collection controller must have
      resources in the body.
    
    Closes-Bug: #1714348
    Change-Id: I1568285c28d227bacf038b3667466a20d3947ca9


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1714348

Title:
  pecan is missing some body validation logic from legacy API

Status in neutron:
  Fix Released

Bug description:
  The legacy controller validated the following things that the pecan
  API is not.

  * delete requests have no body

  * the body must contain a resource or resources when POSTing to the
  general collection controller

  * All POSTed json must be a dict

  
  These gaps were discovered when switching the unit tests to use pecan instead of the old legacy API.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1714348/+subscriptions


References