yahoo-eng-team team mailing list archive

[Launchpad Bug Tracker <1705147@xxxxxxxxxxxxxxxxxx>]

This bug was fixed in the package cloud-init -
0.7.9-233-ge586fe35-0ubuntu1~16.04.1

---------------
cloud-init (0.7.9-233-ge586fe35-0ubuntu1~16.04.1) xenial-proposed; urgency=medium

  * debian/cloud-init.templates: enable Scaleway cloud.
  * debian/cloud-init.templates: enable Aliyun cloud.
  * drop the following cherry picks, now incorporated in snapshot.
    + debian/patches/cpick-5fb49bac-azure-identify-platform...
    + debian/patches/cpick-003c6678-net-remove-systemd-link...
    + debian/patches/cpick-1cd4323b-azure-remove-accidental...
    + debian/patches/cpick-ebc9ecbc-Azure-Add-network-config...
    + debian/patches/cpick-11121fe4-systemd-make-cloud-final...
  * debian/patches/stable-release-no-jsonschema-dep.patch:
    add patch to remove optional dependency on jsonschema.
  * New upstream snapshot.
    - cloudinit.net: add initialize_network_device function and tests
      [Chad Smith]
    - makefile: fix ci-deps-ubuntu target [Chad Smith]
    - tests: adjust locale integration test to parse default locale.
    - tests: remove 'yakkety' from releases as it is EOL.
    - centos: do not package systemd-fsck drop-in.
    - systemd: make systemd-fsck run after cloud-init.service (LP: #1691489)
    - tests: Add initial tests for EC2 and improve a docstring.
    - locale: Do not re-run locale-gen if provided locale is system default.
    - archlinux: fix set hostname usage of write_file. [Joshua Powers]
    - sysconfig: support subnet type of 'manual'.
    - tools/run-centos: make running with no argument show help.
    - Drop rand_str() usage in DNS redirection detection
      [Bob Aman] (LP: #1088611)
    - sysconfig: use MACADDR on bonds/bridges to configure mac_address
      [Ryan Harper]
    - net: eni route rendering missed ipv6 default route config
      [Ryan Harper] (LP: #1701097)
    - sysconfig: enable mtu set per subnet, including ipv6 mtu
      [Ryan Harper]
    - sysconfig: handle manual type subnets [Ryan Harper]
    - sysconfig: fix ipv6 gateway routes [Ryan Harper]
    - sysconfig: fix rendering of bond, bridge and vlan types.
      [Ryan Harper]
    - Templatize systemd unit files for cross distro deltas. [Ryan Harper]
    - sysconfig: ipv6 and default gateway fixes. [Ryan Harper]
    - net: fix renaming of nics to support mac addresses written in upper
      case. (LP: #1705147)
    - tests: fixes for issues uncovered when moving to python 3.6.
    - sysconfig: include GATEWAY value if set in subnet
      [Ryan Harper]
    - Scaleway: add datasource with user and vendor data for Scaleway.
      [Julien Castets]
    - Support comments in content read by load_shell_content.
    - cloudinitlocal fail to run during boot [Hongjiang Zhang]
    - doc: fix disk setup example table_type options [Sandor Zeestraten]
    - tools: Fix exception handling. [Joonas Kylmälä]
    - tests: fix usage of mock in GCE test.
    - test_gce: Fix invalid mock of platform_reports_gce to return False
      [Chad Smith]
    - test: fix incorrect keyid for apt repository.  [Joshua Powers]
    - tests: Update version of pylxd [Joshua Powers]
    - write_files: Remove log from helper function signatures.
      [Andrew Jorgensen]
    - doc: document the cmdline options to NoCloud [Brian Candler]
    - read_dmi_data: always return None when inside a container. (LP: #1701325)
    - requirements.txt: remove trailing white space.
    - Tests: Simplify the check on ssh-import-id [Joshua Powers]
    - tests: update ntp tests after sntp added [Joshua Powers]
    - FreeBSD: Make freebsd a variant, fix unittests and
      tools/build-on-freebsd.
    - FreeBSD: fix test failure
    - FreeBSD: replace ifdown/ifup with "ifconfig down" and "ifconfig up".
      [Hongjiang Zhang]
    - FreeBSD: fix cdrom mounting failure if /mnt/cdrom/secure did not exist.
      [Hongjiang Zhang]
    - main: Don't use templater to format the welcome message
      [Andrew Jorgensen]
    - docs: Automatically generate module docs form schema if present.
      [Chad Smith]
    - debian: fix path comment in /etc/hosts template. [Jens Sandmann]
    - suse: add hostname and fully qualified domain to template.
      [Jens Sandmann]
    - write_file(s): Print permissions as octal, not decimal [Andrew Jorgensen]
    - ci deps: Add --test-distro to read-dependencies to install all deps
      [Chad Smith]
    - tools/run-centos: cleanups and move to using read-dependencies
    - pkg build ci: Add make ci-deps-<distro> target to install pkgs
      [Chad Smith]
    - selinux: Allow restorecon to be non-fatal. [Ryan Harper]
    - net: Allow netinfo subprocesses to return 0 or 1 due to selinux.
      [Ryan Harper]
    - net: Allow for NetworkManager configuration [Ryan McCabe]
    - Use distro release version to determine if we use systemd in redhat spec
      [Ryan Harper]
    - net: normalize data in network_state object
    - Integration Testing: tox env, pyxld 2.2.3, and revamp framework
      [Wesley Wiedenmeier]
    - Chef: Update omnibus url to chef.io, minor doc changes. [JJ Asghar]
    - tools: add centos scripts to build and test [Joshua Powers]
    - Drop cheetah python module as it is not needed by trunk [Ryan Harper]
    - rhel/centos spec cleanups.
    - cloud.cfg: move to a template.  setup.py changes along the way.
    - Makefile: add deb-src and srpm targets. use PYVER more places.
    - makefile: fix python 2/3 detection in the Makefile [Chad Smith]
    - snap: Removing snapcraft plug line [Joshua Powers]
    - RHEL/CentOS: Fix default routes for IPv4/IPv6 configuration.
      [Andreas Karis]
    - test: Fix pyflakes complaint of unused import. [Joshua Powers]
    - NoCloud: support seed of nocloud from smbios information
      [Vladimir Pouzanov] (LP: #1691772)
    - net: when selecting a network device, use natural sort order
      [Marc-Aurèle Brothier]
    - fix typos and remove whitespace in various docs [Stephan Telling]
    - systemd: Fix typo in comment in cloud-init.target. [Chen-Han Hsiao]
    - Tests: Skip jsonschema related unit tests when dependency is absent.
      [Chad Smith]
    - tools/net-convert.py: support old cloudinit versions by using kwargs.
    - ntp: Add schema definition and passive schema validation.
      [Chad Smith] (LP: #1692916)
    - Fix eni rendering for bridge params that require repeated key for
      values. [Ryan Harper] (LP: #1706752)
    - AliYun: Enable platform identification and enable by default.
      [Junjie Wang] (LP: #1638931)

 -- Scott Moser <smoser@xxxxxxxxxx>  Mon, 31 Jul 2017 16:36:16 -0400

** Changed in: cloud-init (Ubuntu Xenial)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to cloud-init.
https://bugs.launchpad.net/bugs/1705147

Title:
  cloud-init interface renaming should apply .lower() to mac_address
  values to match sysfs entries

Status in cloud-init:
  Fix Committed
Status in cloud-init package in Ubuntu:
  Fix Released
Status in cloud-init source package in Xenial:
  Fix Released
Status in cloud-init source package in Zesty:
  Fix Released

Bug description:
  === Begin SRU Template ===
  [Impact]
  cloud-init takes network configuration input in a variety of formats.
  It then applies that network configuration, including renaming devices
  based on their mac address and provided name.

  If the mac address provided contained upper case letters (hex values,
  so A-F) then cloud-init would fail to rename the devices and show a
  WARN message in /var/log/cloud-init.log.

  The warn message would look like:
    Failed to rename devices: [nic not present] Cannot rename 
      mac=00:16:3E:FC:3D:65 to eth0, not available.

  [Test Case]
  The basic idea below is:
   a.) launch an lxd instance with proposed version of cloud-init.
   b.) inside instance, change the provided network config to use upper case
       for mac addresses.
   c.) clean the system and reboot.
   d.) check no errors in /var/log/cloud-init.log

  ## launch an instance.
  $ release=xenial
  $ ref=$release-proposed
  $ lxc-proposed-snapshot --proposed --publish $release $ref
  $ lxc launch $ref $name
  $ lxc exec $name -- /bin/bash

  
  ## inside
  % read lower < /sys/class/net/eth0/address
  % echo $lower
  00:16:3e:fc:3d:65

  % upper=$(echo "$lower" | tr '[a-z]' '[A-Z]')
  % sed -i.dist -e 's,\( *\)name: eth0,\1name: nic0\n\1mac_address: "'$upper'",' \
       /var/lib/cloud/seed/nocloud-net/network-config
  % ( cd /var/lib/cloud/seed/nocloud-net/ && diff -u network-config.dist network-config )
  --- network-config.dist 2017-08-01 20:44:48.445568094 +0000
  +++ network-config   2017-08-01 20:44:58.277456919 +0000
  @@ -1,7 +1,8 @@
   version: 1
   config:
       - type: physical
  -      name: eth0
  +      name: nic0
  +      mac_address: "00:16:3E:5D:72:AE"
         subnets:
             - type: dhcp
               control: auto

  ## clean up skipping the 'seed' directory.
  % ( cd /var/lib/cloud && for i in *; do [ "$i" = "seed" ] || rm -Rf $i; done )
  % rm -Rf /var/log/cloud-init*
  % reboot

  ## back outside, wait a bit, then

  % lxc exec $name -- /bin/bash
  % grep WARN /var/log/cloud-init.log || echo "no warnings"

  % ip addr show nic0
  90: nic0@if91: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
      link/ether 00:16:3e:5d:72:ae brd ff:ff:ff:ff:ff:ff link-netnsid 0
      inet 10.75.205.253/24 brd 10.75.205.255 scope global nic0
         valid_lft forever preferred_lft forever
      inet6 fe80::216:3eff:fe5d:72ae/64 scope link 
         valid_lft forever preferred_lft forever

  [Regression Potential]
  Regression potential here should be very low.  The fix was essentially to
  be more liberal on matching mac addresses by using '.lower()' on both values.

  [Other Info]
  Upstream commit at
    https://git.launchpad.net/cloud-init/commit/?id=c0060fe489

  lxc-proposed-snapshot is
    https://git.launchpad.net/~smoser/cloud-init/+git/sru-info/tree/bin/lxc-proposed-snapshot
  It publishes an image to lxd with proposed enabled and cloud-init upgraded.

  === End SRU Template ===

  
  When supplying a network config to cloud-init with MAC address values using Upper case letters, this will fail to match MAC address values returned from sysfs.  THe result is that cloud-init gives up on the renaming of the interface.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-init/+bug/1705147/+subscriptions