← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1718725] [NEW] non-api bound filters in instance index page didn't work

 

Public bug reported:

The issue was observed on latest code and can be reproduced as below:

- go to Admin dashboard instance index page
- select "image name" filter
- input a valid image name value (note: there are instances created with this image)
- press filter button
- a new page is returned with all instance, instead of instances with that image name

The same issue exists for "project" and "flavor name" filter (all are
non-api bound filters).

Project dashboard has same issue too.

For Admin dashboard, I think the issue is with these code:

        if 'project' in search_opts and \
                not swap_filter(tenants, search_opts, 'project', 'tenant_id'):
                self._more = False
                return instances
        elif 'image_name' in search_opts and \
                not swap_filter(images, search_opts, 'image_name', 'image'):
                self._more = False
                return instances
        elif "flavor_name" in search_opts and \
                not swap_filter(flavors, search_opts, 'flavor_name', 'flavor'):
                self._more = False
                return instances

>From what I can tell, they effectively do nothing unless user input
invalid filter values. That explains why these filter don't work when
user input valid filter values.

For Project dashboard, I don't find code that process the above filters.
Bug?

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1718725

Title:
  non-api bound filters in instance index page didn't work

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  The issue was observed on latest code and can be reproduced as below:

  - go to Admin dashboard instance index page
  - select "image name" filter
  - input a valid image name value (note: there are instances created with this image)
  - press filter button
  - a new page is returned with all instance, instead of instances with that image name

  The same issue exists for "project" and "flavor name" filter (all are
  non-api bound filters).

  Project dashboard has same issue too.

  For Admin dashboard, I think the issue is with these code:

          if 'project' in search_opts and \
                  not swap_filter(tenants, search_opts, 'project', 'tenant_id'):
                  self._more = False
                  return instances
          elif 'image_name' in search_opts and \
                  not swap_filter(images, search_opts, 'image_name', 'image'):
                  self._more = False
                  return instances
          elif "flavor_name" in search_opts and \
                  not swap_filter(flavors, search_opts, 'flavor_name', 'flavor'):
                  self._more = False
                  return instances

  From what I can tell, they effectively do nothing unless user input
  invalid filter values. That explains why these filter don't work when
  user input valid filter values.

  For Project dashboard, I don't find code that process the above
  filters. Bug?

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1718725/+subscriptions


Follow ups