yahoo-eng-team team mailing list archive

[Daniel Park <daniepar@xxxxxxxxx>]

Public bug reported:

In some parts of the code, Keystone is raising an IOError with just a
string. While this does work, it would be helpful to include an error
number using the errno library.

https://github.com/openstack/keystone/blob/68f1043ce2a96e3d9a1e458c825800c061c95fe2/keystone/identity/backends/ldap/common.py#L595
https://github.com/openstack/keystone/blob/68f1043ce2a96e3d9a1e458c825800c061c95fe2/keystone/identity/backends/ldap/common.py#L607
https://github.com/openstack/keystone/blob/0d845e0316955eca5ed85b610d587d6667ea2bac/keystone/federation/idp.py#L496

This would also prevent a UnicodeError exception from being thrown in an
environment that is using an older version of oslo.i18n (< 3.1.0).

** Affects: keystone
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1718789

Title:
  Error number should be used when throwing IOError exception

Status in OpenStack Identity (keystone):
  New

Bug description:
  In some parts of the code, Keystone is raising an IOError with just a
  string. While this does work, it would be helpful to include an error
  number using the errno library.

  https://github.com/openstack/keystone/blob/68f1043ce2a96e3d9a1e458c825800c061c95fe2/keystone/identity/backends/ldap/common.py#L595
  https://github.com/openstack/keystone/blob/68f1043ce2a96e3d9a1e458c825800c061c95fe2/keystone/identity/backends/ldap/common.py#L607
  https://github.com/openstack/keystone/blob/0d845e0316955eca5ed85b610d587d6667ea2bac/keystone/federation/idp.py#L496

  This would also prevent a UnicodeError exception from being thrown in
  an environment that is using an older version of oslo.i18n (< 3.1.0).

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1718789/+subscriptions