yahoo-eng-team team mailing list archive

[Eric Fried <efried@xxxxxxxxxx>]

** Changed in: nova-powervm
   Importance: Undecided => High

** Changed in: nova-powervm
       Status: New => Fix Released

** Changed in: nova-powervm
     Assignee: (unassigned) => Eric Fried (efried)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1718545

Title:
  [vnc]vncserver_proxyclient_address and [vnc]vncserver_listen removed
  without deprecation

Status in OpenStack Compute (nova):
  Fix Released
Status in nova-powervm:
  Fix Released

Bug description:
  [0] removed options [vnc]vncserver_proxyclient_address and
  [vnc]vncserver_listen without a deprecation period.  Lemme splain:

  Take for example vncserver_proxyclient_address.  It was originally
  [DEFAULT]vncserver_proxyclient_address.  That was moved to
  [vnc]vncserver_proxyclient_address via [1].  We've had a nice long
  deprecation period (~18mo) during which either of those would work.
  So it would be reasonable at this time to remove support for
  [DEFAULT]vncserver_proxyclient_address.  But by renaming the option
  without changing its deprecated_group to `vnc`, we've instead *left*
  support for [DEFAULT]vncserver_proxyclient_address while *removing*
  support for the newer [vnc]vncserver_proxyclient_address without a
  deprecation period.

  I noticed this when running tox against nova-powervm with the latest
  nova.  nova-powervm paid attention to the deprecation and switched
  over to [vnc]vncserver_proxyclient_address.  Now it fails a test with:

  Captured traceback:
  ~~~~~~~~~~~~~~~~~~~
      Traceback (most recent call last):
        File "/home/efried/Neo/nova-powervm/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
          return func(*args, **keywargs)
        File "nova_powervm/tests/virt/powervm/test_driver.py", line 1666, in test_get_vnc_console
          resp = self.drv.get_vnc_console(mock.ANY, self.inst)
        File "nova_powervm/virt/powervm/driver.py", line 1727, in get_vnc_console
          host = CONF.vnc.vncserver_proxyclient_address
        File "/home/efried/Neo/nova-powervm/.tox/py27/local/lib/python2.7/site-packages/oslo_config/cfg.py", line 3363, in __getattr__
          return self._conf._get(name, self._group)
        File "/home/efried/Neo/nova-powervm/.tox/py27/local/lib/python2.7/site-packages/oslo_config/cfg.py", line 2925, in _get
          value = self._do_get(name, group, namespace)
        File "/home/efried/Neo/nova-powervm/.tox/py27/local/lib/python2.7/site-packages/oslo_config/cfg.py", line 2942, in _do_get
          info = self._get_opt_info(name, group)
        File "/home/efried/Neo/nova-powervm/.tox/py27/local/lib/python2.7/site-packages/oslo_config/cfg.py", line 3099, in _get_opt_info
          raise NoSuchOptError(opt_name, group)
      oslo_config.cfg.NoSuchOptError: no such option vncserver_proxyclient_address in group [vnc]

  But anyone should be able to repro by spinning up compute with
  [vnc]vncserver_proxyclient_address and trying to open a console.

  [0] https://review.openstack.org/#/c/498387/
  [1] https://review.openstack.org/#/c/263763/

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1718545/+subscriptions