← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1719275] Re: Linux Bridge bridge_mappings, remove unnecessary logic to retrieve bridge name

 

Reviewed:  https://review.openstack.org/507030
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bb550de3d78e58bb811dc5ad1da69ddb356a3f9d
Submitter: Jenkins
Branch:    master

commit bb550de3d78e58bb811dc5ad1da69ddb356a3f9d
Author: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@xxxxxxxxx>
Date:   Mon Sep 25 10:27:40 2017 +0100

    Linux Bridge, remove unnecessary logic to retrieve bridge name
    
    In [1], the function "get_existing_bridge_name" retrieves the value of a
    dict using the method get. Before this, it checks if the key value used is
    "True". This check is not needed using the dictionary "get" method.
    
    [1] https://github.com/openstack/neutron/blob/11.0.0.0rc3/neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py#L155
    
    Change-Id: Iba020c6b297228ae48bbd2a19f540b0152570317
    Closes-Bug: #1719275


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1719275

Title:
  Linux Bridge bridge_mappings, remove unnecessary logic to retrieve
  bridge name

Status in neutron:
  Fix Released

Bug description:
  In [1], the function "get_existing_bridge_name" retrieves the value of
  a dict using the method get. Before this, it checks if the key value
  used is "True". This check is not needed using the dictionary "get"
  method.

  [1]
  https://github.com/openstack/neutron/blob/11.0.0.0rc3/neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py#L155

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1719275/+subscriptions


References