← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1721423] [NEW] [Performance] Bad performance on instances list panel

 

Public bug reported:

I just found there is no cache for microversion check which may cause
almost 40 unnecessary API calls.

There are two actions for instances table need to check the microversion in allowed() function, see
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tables.py#L870

but unfortunately, there is no cache for this check, see
https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L60

And function get_microversion(request, feature) is also used by other
functions. Based on my test, after adding cache for this function, about
3+ seconds are saved.

** Affects: horizon
     Importance: Undecided
     Assignee: Feilong Wang (flwang)
         Status: New

** Changed in: horizon
     Assignee: (unassigned) => Feilong Wang (flwang)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1721423

Title:
  [Performance] Bad performance on instances list panel

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  I just found there is no cache for microversion check which may cause
  almost 40 unnecessary API calls.

  There are two actions for instances table need to check the microversion in allowed() function, see
  https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tables.py#L870

  but unfortunately, there is no cache for this check, see
  https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L60

  And function get_microversion(request, feature) is also used by other
  functions. Based on my test, after adding cache for this function,
  about 3+ seconds are saved.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1721423/+subscriptions


Follow ups