← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1721761] [NEW] Fix 500 if user passes name with more than 80 characters

 

Public bug reported:

https://review.openstack.org/507433
Dear bug triager. This bug was created since a commit was marked with DOCIMPACT.
Your project "openstack/glance" is set up so that we directly report the documentation bugs against it. If this needs changing, the docimpact-group option needs to be added for the project. You can ask the OpenStack infra team (#openstack-infra on freenode) for help if you need to.

commit 2562da28c6171cc5372d3a695af00e22134a360b
Author: Dinesh Bhor <dinesh.bhor@xxxxxxxxxxx>
Date:   Tue Sep 19 18:35:56 2017 +0530

    Fix 500 if user passes name with more than 80 characters
    
    Following apis are returning 500 error if user passes name with more
    than 80 characters:
    * md-tag-create
    * md-tag-update
    * md-object-create
    * md-object-update
    * md-property-create
    * md-property-update
    
    This happens because there is a discrepancy in db column length and
    glance-api length check in schema validation. In database the 'name'
    field for these API's is defined as of maximum 80 characters and in
    schema it is defined as of maximum 255 characters. So if user passes
    name with more than 80 characters and less than 255 characters
    database fails to store that value and shouts with following error
    which leads to 500 error to API user:
    
    (pymysql.err.DataError) (1406, u"Data too long for column 'name' at
    row 1")
    
    Fixed this issue by changing the maximum allowed length for 'name'
    from 255 to 80 in schema validation.
    
    APIImpact
    DocImpact
    Closes-Bug: #1719252
    Change-Id: I4ae67457c3e4f5a6bfc3c1db2d305a9b7587395f

** Affects: glance
     Importance: Undecided
         Status: New


** Tags: doc glance

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1721761

Title:
      Fix 500 if user passes name with more than 80 characters

Status in Glance:
  New

Bug description:
  https://review.openstack.org/507433
  Dear bug triager. This bug was created since a commit was marked with DOCIMPACT.
  Your project "openstack/glance" is set up so that we directly report the documentation bugs against it. If this needs changing, the docimpact-group option needs to be added for the project. You can ask the OpenStack infra team (#openstack-infra on freenode) for help if you need to.

  commit 2562da28c6171cc5372d3a695af00e22134a360b
  Author: Dinesh Bhor <dinesh.bhor@xxxxxxxxxxx>
  Date:   Tue Sep 19 18:35:56 2017 +0530

      Fix 500 if user passes name with more than 80 characters
      
      Following apis are returning 500 error if user passes name with more
      than 80 characters:
      * md-tag-create
      * md-tag-update
      * md-object-create
      * md-object-update
      * md-property-create
      * md-property-update
      
      This happens because there is a discrepancy in db column length and
      glance-api length check in schema validation. In database the 'name'
      field for these API's is defined as of maximum 80 characters and in
      schema it is defined as of maximum 255 characters. So if user passes
      name with more than 80 characters and less than 255 characters
      database fails to store that value and shouts with following error
      which leads to 500 error to API user:
      
      (pymysql.err.DataError) (1406, u"Data too long for column 'name' at
      row 1")
      
      Fixed this issue by changing the maximum allowed length for 'name'
      from 255 to 80 in schema validation.
      
      APIImpact
      DocImpact
      Closes-Bug: #1719252
      Change-Id: I4ae67457c3e4f5a6bfc3c1db2d305a9b7587395f

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1721761/+subscriptions


Follow ups