yahoo-eng-team team mailing list archive

[OpenStack Infra <1718226@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/483969
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ad33ae5771de3a90472ca836a7b2292c6334fe9e
Submitter: Jenkins
Branch:    master

commit ad33ae5771de3a90472ca836a7b2292c6334fe9e
Author: Balazs Gibizer <balazs.gibizer@xxxxxxxxxxxx>
Date:   Fri Jul 14 17:19:03 2017 +0200

    use already loaded BDM in instance.create
    
    In I18e7483ec9a484a660e1d306fdc0986e1d5f952b BDM was added to the instance
    notifications. In general to add BDM to the payload an exta DB query is
    needed. However the BDM is already locaded before the
    notify_about_instance_create is called to send the notification. In this cases
    loading the BDM again is unnecessary as the already loaded BDM can be reused.
    
    This patch makes sure that notify_about_instance_create is called with the
    already loaded BDM.
    
    The remaining instance related versioned notification calls does not have
    BDM already loaded.
    
    Change-Id: Ic25de45c18348206f0309da6d4997f4bf336acb2
    Closes-Bug: #1718226


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1718226

Title:
  bdm is wastefully loaded for versioned instance notifications

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The block device mapping is included in the instance versioned
  notifications with I18e7483ec9a484a660e1d306fdc0986e1d5f952b. This
  means that if so configured nova will load the BDM from the DB for
  every instance notification. This is wasteful when the BDM is already
  loaded in the context of the call from where the notification is
  emitted. In this case that BDM should be reused to remove the
  unnecessary DB load.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1718226/+subscriptions