yahoo-eng-team team mailing list archive

[Thomas Morin <1722842@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The code at [1] assumes that the resource to update is a base resource
and the code update its dictionary.  When the resource is a sub-
resource, ie. a {'parent': ... , 'parameters': {..} } dictionary, the
result of the update() call is that the content of 'parameters' is
overwritten, while the correct thing to here would be to update the
content of parameters with the new/changed attributes introduced by the
extension.

(This issue is blocking the implementation of the bgpvpn routes-control
blueprint [2] which is about an API extension that adds attributes to
the "router_association" sub-resource introduced by the bgpvpn API
extension.)

[1] https://github.com/openstack/neutron/blob/master/neutron/api/extensions.py#L348
[2] https://blueprints.launchpad.net/bgpvpn/+spec/routes-control

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1722842

Title:
  API extension framework: impossible to extend a sub-resource

Status in neutron:
  New

Bug description:
  The code at [1] assumes that the resource to update is a base resource
  and the code update its dictionary.  When the resource is a sub-
  resource, ie. a {'parent': ... , 'parameters': {..} } dictionary, the
  result of the update() call is that the content of 'parameters' is
  overwritten, while the correct thing to here would be to update the
  content of parameters with the new/changed attributes introduced by
  the extension.

  (This issue is blocking the implementation of the bgpvpn routes-
  control blueprint [2] which is about an API extension that adds
  attributes to the "router_association" sub-resource introduced by the
  bgpvpn API extension.)

  [1] https://github.com/openstack/neutron/blob/master/neutron/api/extensions.py#L348
  [2] https://blueprints.launchpad.net/bgpvpn/+spec/routes-control

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1722842/+subscriptions