← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1722967] [NEW] init_handler argument error in ovs agent

 

Public bug reported:

I start a DevStack environment with trunk port feature enabled. In the
log of ovs agent, I see the following error message:

neutron-openvswitch-agent[26247]: ERROR neutron_lib.callbacks.manager [None req-505cd81e-24d2-4aac-992f-e1614137c1ee None None] Error during notification for neutron.services.trunk.drivers.openvswitch.agent.driver.init_handler-8755440873883 Open vSwitch agent, after_init: TypeError: init_handler() got an unexpected keyword argument 'payload'
neutron-openvswitch-agent[26247]: ERROR neutron_lib.callbacks.manager Traceback (most recent call last):
neutron-openvswitch-agent[26247]: ERROR neutron_lib.callbacks.manager   File "/usr/local/lib/python2.7/dist-packages/neutron_lib/callbacks/manager.py", line 171, in _notify_loop
neutron-openvswitch-agent[26247]: ERROR neutron_lib.callbacks.manager     callback(resource, event, trigger, **kwargs)
neutron-openvswitch-agent[26247]: ERROR neutron_lib.callbacks.manager TypeError: init_handler() got an unexpected keyword argument 'payload'
neutron-openvswitch-agent[26247]: ERROR neutron_lib.callbacks.manager

I guess the reason is that this patch[1] introduces the following
change:

-    def register(self, resource, event, trigger, **kwargs):
+    def register(self, resource, event, trigger, payload=None):

but the init_handler function is still defined like this[2]:

def init_handler(resource, event, trigger, agent=None):

[1] https://github.com/openstack/neutron/commit/7a6fa742088563ad06597c2430a30a35cca7db42
[2] https://github.com/openstack/neutron/blob/master/neutron/services/trunk/drivers/openvswitch/agent/driver.py

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1722967

Title:
  init_handler argument error in ovs agent

Status in neutron:
  New

Bug description:
  I start a DevStack environment with trunk port feature enabled. In the
  log of ovs agent, I see the following error message:

  neutron-openvswitch-agent[26247]: ERROR neutron_lib.callbacks.manager [None req-505cd81e-24d2-4aac-992f-e1614137c1ee None None] Error during notification for neutron.services.trunk.drivers.openvswitch.agent.driver.init_handler-8755440873883 Open vSwitch agent, after_init: TypeError: init_handler() got an unexpected keyword argument 'payload'
  neutron-openvswitch-agent[26247]: ERROR neutron_lib.callbacks.manager Traceback (most recent call last):
  neutron-openvswitch-agent[26247]: ERROR neutron_lib.callbacks.manager   File "/usr/local/lib/python2.7/dist-packages/neutron_lib/callbacks/manager.py", line 171, in _notify_loop
  neutron-openvswitch-agent[26247]: ERROR neutron_lib.callbacks.manager     callback(resource, event, trigger, **kwargs)
  neutron-openvswitch-agent[26247]: ERROR neutron_lib.callbacks.manager TypeError: init_handler() got an unexpected keyword argument 'payload'
  neutron-openvswitch-agent[26247]: ERROR neutron_lib.callbacks.manager

  I guess the reason is that this patch[1] introduces the following
  change:

  -    def register(self, resource, event, trigger, **kwargs):
  +    def register(self, resource, event, trigger, payload=None):

  but the init_handler function is still defined like this[2]:

  def init_handler(resource, event, trigger, agent=None):

  [1] https://github.com/openstack/neutron/commit/7a6fa742088563ad06597c2430a30a35cca7db42
  [2] https://github.com/openstack/neutron/blob/master/neutron/services/trunk/drivers/openvswitch/agent/driver.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1722967/+subscriptions


Follow ups