← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1724177] [NEW] Sqlalchemy column in_() operator does not allow NULL element

 

Public bug reported:

I met this issue when I was integrating Floating IP OVO objects. There
would be a case that we want to pass router_id=None and
fixed_port_id=None into get_objects() method [1], which eventually leads
to this method [2].

In my case, since when key is "router_id" and value is "[None]", the
in_() clause in Line 205 will not return any matching queries, cause
in_() does not support None element.

We need to add a check if [2] when None is contained in value.

[1] https://review.openstack.org/#/c/396351/34..35/neutron/db/l3_db.py@1429
[2] https://github.com/openstack/neutron/blob/master/neutron/db/_model_query.py#L176

** Affects: neutron
     Importance: Undecided
     Assignee: Lujin Luo (luo-lujin)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => Lujin Luo (luo-lujin)

** Description changed:

  I met this issue when I was integrating Floating IP OVO objects. There
  would be a case that we want to pass router_id=None and
  fixed_port_id=None into get_objects() method [1], which eventually leads
  to this method [2].
  
  In my case, since when key is "router_id" and value is "[None]", the
- in_() clause in Line 205 will not return any matching queries.
+ in_() clause in Line 205 will not return any matching queries, cause
+ in_() does not support None element.
  
  We need to add a check if [2] when None is contained in value.
  
  [1] https://review.openstack.org/#/c/396351/34..35/neutron/db/l3_db.py@1429
  [2] https://github.com/openstack/neutron/blob/master/neutron/db/_model_query.py#L176

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1724177

Title:
  Sqlalchemy column in_() operator does not allow NULL  element

Status in neutron:
  New

Bug description:
  I met this issue when I was integrating Floating IP OVO objects. There
  would be a case that we want to pass router_id=None and
  fixed_port_id=None into get_objects() method [1], which eventually
  leads to this method [2].

  In my case, since when key is "router_id" and value is "[None]", the
  in_() clause in Line 205 will not return any matching queries, cause
  in_() does not support None element.

  We need to add a check if [2] when None is contained in value.

  [1] https://review.openstack.org/#/c/396351/34..35/neutron/db/l3_db.py@1429
  [2] https://github.com/openstack/neutron/blob/master/neutron/db/_model_query.py#L176

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1724177/+subscriptions


Follow ups