yahoo-eng-team team mailing list archive

[OpenStack Infra <1723423@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/511844
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b25928dc0459e44c5cef8c1f16db76d779fbf556
Submitter: Zuul
Branch:    master

commit b25928dc0459e44c5cef8c1f16db76d779fbf556
Author: Dmitry Tantsur <divius.inside@xxxxxxxxx>
Date:   Fri Oct 13 15:18:16 2017 +0200

    Pick ironic nodes without VCPU set
    
    Starting with the Pike release, reporting VCPU/memory/disk is no longer required.
    However, we used VCPU to check if a node is available, so nodes without VCPU in
    their properties were always ignored. This patch changes the logic to use the existing
    _node_resources_unavailable call.
    
    This change also fixes another related issue: when disk or memory are missing from
    properties, the virt driver tries to report zero max_unit for them, which is not
    allowed by placement.
    
    Change-Id: I1bbfc152189252c5c45e6153695a802d17b76690
    Closes-Bug: #1723423


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1723423

Title:
  Ironic node cannot be used if it does not report VCPU

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Even though reporting VCPU is optional, starting with Pike, due to
  code at
  https://github.com/openstack/nova/blob/10661dc5e2e3f2e2f37b6a86ea22f71b4b833fc9/nova/virt/ironic/driver.py#L762
  nodes without VCPU are not recognized. This has to be changes to
  properly call _node_resources_unavailable instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1723423/+subscriptions