yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #68800
[Bug 1723122] Re: missing gabbi coverage for empty resources query string
Reviewed: https://review.openstack.org/511488
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=643ed234daacd84a811cd609be2375e8e9d7d609
Submitter: Zuul
Branch: master
commit 643ed234daacd84a811cd609be2375e8e9d7d609
Author: Chris Dent <cdent@xxxxxxxxxxxxx>
Date: Thu Oct 12 15:14:44 2017 +0100
[placement] Confirm that empty resources query causes 400
When a request is made to /resource_providers or /allocation_candidates
with a 'resources' query parameter, and empty value should lead to a
400. This was indeed happening, but there was no gabbi test coverage for
it. This adds tests at both URLs.
Note that because the query parameter is processed by the same code for
both /resource_providers and /allocation_candidates the test duplicates
a code a path, however, that's an implementation detail that we don't
know at the HTTP API layer.
Change-Id: Ia6fc0ac09efc5407a899de4215a2ba0ba0b017fb
Closes-Bug: #1723122
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1723122
Title:
missing gabbi coverage for empty resources query string
Status in OpenStack Compute (nova):
Fix Released
Bug description:
This is a note to self for sake of bookkeeping.
Coverage reports show that there's zero gabbi coverage for a request
with an empty `resources` query string. As this is relatively simple
to add, may as well have it.
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1723122/+subscriptions
References