← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1542724] Re: Prevent user to remove last location of the image

 

Reviewed:  https://review.openstack.org/513549
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=8026e7f588786a9fc78d6c554725c30b3c4dd8fa
Submitter: Zuul
Branch:    master

commit 8026e7f588786a9fc78d6c554725c30b3c4dd8fa
Author: Brian Rosmaita <rosmaita.fossdev@xxxxxxxxx>
Date:   Thu Oct 19 18:45:42 2017 -0400

    Update api-ref about 403 for image location changes
    
    Add deleting the only location or attempting to set the locations
    to an empty list as another reason why a user might get a 403
    response to a PATCH call.
    
    Change-Id: I2edb072ded11d1b710af0309f0372d1b16042a54
    Closes-bug: #1542724


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1542724

Title:
      Prevent user to remove last location of the image

Status in Glance:
  Fix Released

Bug description:
  https://review.openstack.org/275735
  Dear bug triager. This bug was created since a commit was marked with DOCIMPACT.
  Your project "openstack/glance" is set up so that we directly report the documentation bugs against it. If this needs changing, the docimpact-group option needs to be added for the project. You can ask the OpenStack infra team (#openstack-infra on freenode) for help if you need to.

  commit c5c731c7153d6d46c27260474d2811d504dfac5c
  Author: Erno Kuvaja <jokke@xxxxxx>
  Date:   Tue Jan 19 13:37:05 2016 +0000

      Prevent user to remove last location of the image
      
      If the last location of the image is removed, image transitions back to queued.
      This allows user to upload new data into the existing image record. By
      preventing removal of the last location we prevent the image transition back to
      queued.
      
      This change also prevents doing the same operation via replacing the locations
      with empty list.
      
      SecurityImpact
      DocImpact
      APIImpact
      
      Conflicts:
      	glance/tests/unit/v2/test_images_resource.py
      
      Conflicts:
      	glance/api/v2/images.py
      
      Change-Id: Ieb03aaba887492819f9c58aa67f7acfcea81720e
      Closes-Bug: #1525915
      (cherry picked from commit e9e45baa9aaf58e69964419b6b4fb2048d115a0c)

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1542724/+subscriptions


References