yahoo-eng-team team mailing list archive

[OpenStack Infra <1727988@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/515691
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1d468ef7caefd947f9e6b5a0c7cc3559cb257a52
Submitter: Zuul
Branch:    master

commit 1d468ef7caefd947f9e6b5a0c7cc3559cb257a52
Author: Boden R <bodenvmw@xxxxxxxxx>
Date:   Fri Oct 27 13:44:02 2017 -0600

    revert base extension unit test param removal
    
    Commit I2586f0b11b107d7f57214a0d65bcf7c38a5f0ebb changed the private
    _setUpExtension() method in neutron/tests/unit/extensions/base.py by
    removing a now unused parameter. However consumers are using the private
    method so the resulting change breaks them in some cases.
    
    This patch adds the param back as well as a todo to phase it out by
    moving consumers off it 1st.
    
    Closes-Bug: 1727988
    Change-Id: I782e6d6fb6e575c00644f72602bc90a3d25bc18c


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1727988

Title:
  _setUpExtension signature change breaking unit tests

Status in networking-bgpvpn:
  In Progress
Status in networking-sfc:
  New
Status in neutron:
  Fix Released

Bug description:
  https://review.openstack.org/#/c/514470/ changed the signature for
  _setUpExtension which breaks many unit tests for API extensions in
  neutron-related projects.

     TypeError: _setUpExtension() got multiple values for keyword
  argument 'plural_mappings'

  http://logs.openstack.org/70/513670/7/check/openstack-tox-
  py27/59ddc66/testr_results.html.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/bgpvpn/+bug/1727988/+subscriptions