yahoo-eng-team team mailing list archive

[Cédric Jeanneret <1731190@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Dear Stackers,

While trying to understand an issue with nova instance resize, I just
found you're not using oslo_concurrency.processutils.ssh_execute, but
instead a nova.utils.ssh_execute.

It might be better, for the sake of code maintenance and sanity, to
converge and use the function provided by oslo.concurrency. It
apparently has some more logging capacities.

Apparently, nova.utils.execute just wraps the
oslo_concurrency.processutils.execute in some cases, but not for ssh
commands.

Hence, using ssh_execute from oslo shouldn't be a problem, especially
since it's apparently only used in the the following file/lib and its
related tests: nova/virt/libvirt/volume/remotefs.py

Thank you!

Cheers,

C.

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1731190

Title:
  nova should use oslo_concurrency.processutils.ssh_execute

Status in OpenStack Compute (nova):
  New

Bug description:
  Dear Stackers,

  While trying to understand an issue with nova instance resize, I just
  found you're not using oslo_concurrency.processutils.ssh_execute, but
  instead a nova.utils.ssh_execute.

  It might be better, for the sake of code maintenance and sanity, to
  converge and use the function provided by oslo.concurrency. It
  apparently has some more logging capacities.

  Apparently, nova.utils.execute just wraps the
  oslo_concurrency.processutils.execute in some cases, but not for ssh
  commands.

  Hence, using ssh_execute from oslo shouldn't be a problem, especially
  since it's apparently only used in the the following file/lib and its
  related tests: nova/virt/libvirt/volume/remotefs.py

  Thank you!

  Cheers,

  C.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1731190/+subscriptions