← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1627106] Re: TimeoutException while executing tests adding bridge using OVSDB native

 

Reviewed:  https://review.openstack.org/520176
Committed: https://git.openstack.org/cgit/openstack/ovsdbapp/commit/?id=158ae06bce0f56e93677f94c59f81e5e76ee1ccc
Submitter: Zuul
Branch:    master

commit 158ae06bce0f56e93677f94c59f81e5e76ee1ccc
Author: Terry Wilson <twilson@xxxxxxxxxx>
Date:   Wed Nov 15 13:05:18 2017 -0600

    Don't wait on TRY_AGAIN when calling commit_block()
    
    commit_block() calls idl.run() already, so the seqno has already
    changed, and waiting again could potentially wait until a timeout
    occurs. From the ovs.db.idl docs:
    
     If the final status is Transaction.TRY_AGAIN, wait for
     Idl.change_seqno to change from the saved 'seqno' (it's possible
     that it's already changed, in which case the client should not
     wait at all), then start over from step 1.  Only a call to
     Idl.run() will change the return value of Idl.change_seqno.
     (Transaction.commit_block() calls Idl.run().)
    
    Closes-Bug: #1627106
    Change-Id: I1e5f4627f0488ba15ba2fb3509504bcf1b787b07


** Changed in: ovsdbapp
       Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1627106

Title:
  TimeoutException while executing tests adding bridge using OVSDB
  native

Status in neutron:
  Confirmed
Status in ovsdbapp:
  Fix Released

Bug description:
  http://logs.openstack.org/91/366291/12/check/gate-neutron-dsvm-
  functional-ubuntu-trusty/a23c816/testr_results.html.gz

  Traceback (most recent call last):
    File "neutron/tests/base.py", line 125, in func
      return f(self, *args, **kwargs)
    File "neutron/tests/functional/agent/ovsdb/test_impl_idl.py", line 62, in test_post_commit_vswitchd_completed_no_failures
      self._add_br_and_test()
    File "neutron/tests/functional/agent/ovsdb/test_impl_idl.py", line 56, in _add_br_and_test
      self._add_br()
    File "neutron/tests/functional/agent/ovsdb/test_impl_idl.py", line 52, in _add_br
      tr.add(ovsdb.add_br(self.brname))
    File "neutron/agent/ovsdb/api.py", line 76, in __exit__
      self.result = self.commit()
    File "neutron/agent/ovsdb/impl_idl.py", line 72, in commit
      'timeout': self.timeout})
  neutron.agent.ovsdb.api.TimeoutException: Commands [AddBridgeCommand(name=test-br6925d8e2, datapath_type=None, may_exist=True)] exceeded timeout 10 seconds

  
  I suspect this one may hit us because we finally made timeout working with Icd745514adc14730b9179fa7a6dd5c115f5e87a5.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1627106/+subscriptions


References