yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem.os@xxxxxxxxx>]

Public bug reported:

Due to this recent change:

https://github.com/openstack/nova/commit/984dd8ad6add4523d93c7ce5a666a32233e02e34

And the fact that volume-backed instances don't store the
instance.image_ref value to indicate they are volume-backed, this
condition will always evaluate to True:

https://github.com/openstack/nova/blob/984dd8ad6add4523d93c7ce5a666a32233e02e34/nova/compute/api.py#L2959

And we'll unnecessarily call through the scheduler again to validate the
instance on the original host during the rebuild even if the image isn't
changing.

For a volume-backed instance, we have to get the original image_id from
the volume's volume_image_metadata field:

https://review.openstack.org/#/c/520686/

** Affects: nova
     Importance: Undecided
         Status: Triaged


** Tags: rebuild

** Changed in: nova
       Status: New => Triaged

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1732947

Title:
  volume-backed instance rebuild with no image change is still going
  through scheduler

Status in OpenStack Compute (nova):
  Triaged

Bug description:
  Due to this recent change:

  https://github.com/openstack/nova/commit/984dd8ad6add4523d93c7ce5a666a32233e02e34

  And the fact that volume-backed instances don't store the
  instance.image_ref value to indicate they are volume-backed, this
  condition will always evaluate to True:

  https://github.com/openstack/nova/blob/984dd8ad6add4523d93c7ce5a666a32233e02e34/nova/compute/api.py#L2959

  And we'll unnecessarily call through the scheduler again to validate
  the instance on the original host during the rebuild even if the image
  isn't changing.

  For a volume-backed instance, we have to get the original image_id
  from the volume's volume_image_metadata field:

  https://review.openstack.org/#/c/520686/

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1732947/+subscriptions