yahoo-eng-team team mailing list archive

[OpenStack Infra <1678056@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/515034
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=32fd58813f8247641a6b574b5f01528b29d48b76
Submitter: Zuul
Branch:    master

commit 32fd58813f8247641a6b574b5f01528b29d48b76
Author: Surya Seetharaman <suryaseetharaman.9@xxxxxxxxx>
Date:   Wed Oct 25 13:43:43 2017 +0200

    cleanup mapping/reqspec after archive instance
    
    This patch aims at deleting the records of the archived instances from
    the instance_mappings and request_specs tables in the API database
    immediately following their archival from instances to shadow_instances
    table. So upon running the 'nova-manage db archive_deleted_rows' command
    the records of the archived instances will be automatically removed from
    the instance_mappings and request_specs tables as well. A warning has
    also been added to fix the issue of 'nova-manage verify_instance'
    returning a valid instance mapping even after the instance is deleted.
    
    The patch also adds InstanceMappingList.destory_bulk() and
    RequestSpec.destroy_bulk() methods for ease of bulk deletion of records.
    
    Change-Id: I483701a55576c245d091ff086b32081b392f746e
    Closes-Bug: #1724621
    Closes-Bug: #1678056


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1678056

Title:
  RequestSpec records are never deleted when destroying an instance

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) newton series:
  New
Status in OpenStack Compute (nova) ocata series:
  New

Bug description:
  When an instance is created, Nova adds a record in the API DB
  'request_specs' table by providing the user request. That's used by
  the scheduler for knowing the boot request, also when the instance is
  moved afterwards.

  That said, when destroying the instance, we don't delete the related RequestSpec record.
  Of course, operators could run a script for deleting them by checking the instance UUIDs, but it would be better if when an instance is hard-deleted (ie. when operators don't use [DEFAULT]/reclaim_instance_interval for restoring deleted instances), we could then delete the RequestSpec too.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1678056/+subscriptions