yahoo-eng-team team mailing list archive

[Ghanshyam Mann <ghanshyammann@xxxxxxxxx>]

Public bug reported:

'all_tenants'  and 'all_projects'  are query param to list the resources
for all tenants/projects.

Checking of this query param in code is different in different APIs.
-  GET /servers API checks the value of 'all_tenants' as bool[1]. 
-  other APIs just checks the present of it in req, like GET /os-server-groups, /os-fping

api-ref mentioned this param types as integer, boolean or string.

It is good to mention this query param type consistently to avoid
confusion for users.

..1
https://github.com/openstack/nova/blob/e9104dbaef9bbccc6b19811125d439fdf9558428/nova/api/openstack/compute/servers.py#L265

..2 
https://github.com/openstack/nova/blob/e9104dbaef9bbccc6b19811125d439fdf9558428/nova/api/openstack/compute/server_groups.py#L138

https://github.com/openstack/nova/blob/e9104dbaef9bbccc6b19811125d439fdf9558428/nova/api/openstack/compute/fping.py#L75

** Affects: nova
     Importance: Undecided
     Assignee: Ghanshyam Mann (ghanshyammann)
         Status: In Progress

** Changed in: nova
     Assignee: (unassigned) => Ghanshyam Mann (ghanshyammann)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1734427

Title:
  'all_tenants'  'all_projects'  query param is not only integer as
  mentioned in api-ref

Status in OpenStack Compute (nova):
  In Progress

Bug description:
  'all_tenants'  and 'all_projects'  are query param to list the
  resources for all tenants/projects.

  Checking of this query param in code is different in different APIs.
  -  GET /servers API checks the value of 'all_tenants' as bool[1]. 
  -  other APIs just checks the present of it in req, like GET /os-server-groups, /os-fping

  api-ref mentioned this param types as integer, boolean or string.

  It is good to mention this query param type consistently to avoid
  confusion for users.

  ..1
  https://github.com/openstack/nova/blob/e9104dbaef9bbccc6b19811125d439fdf9558428/nova/api/openstack/compute/servers.py#L265

  ..2 
  https://github.com/openstack/nova/blob/e9104dbaef9bbccc6b19811125d439fdf9558428/nova/api/openstack/compute/server_groups.py#L138

  https://github.com/openstack/nova/blob/e9104dbaef9bbccc6b19811125d439fdf9558428/nova/api/openstack/compute/fping.py#L75

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1734427/+subscriptions