yahoo-eng-team team mailing list archive

[OpenStack Infra <1734244@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/522706
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=f8e79ab50775bcf5964c7547297577d0a3b82519
Submitter: Zuul
Branch:    master

commit f8e79ab50775bcf5964c7547297577d0a3b82519
Author: wangxiyuan <wangxiyuan@xxxxxxxxxx>
Date:   Fri Nov 24 12:40:20 2017 +0800

    Fix 500 error when create trust with invalid role key
    
    When create trust with invalid role key(neither 'id' nor
    'name'), Keystone should raise 400 BadRequest, instead of
    500 Internal Error.
    
    This patch removed the redundant loops in
    _normalize_role_list as well.
    
    Change-Id: I62bd201c1dda7b573e2ee8b97322c1f25275892c
    Closes-bug: #1734244


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1734244

Title:
  keystone raise 500 error when create trust with invalid role key

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  When a user try to create a trust, if the "roles" in the request body
  contains some invalid keys(except "id" and "name"), Keystone will
  raise 500 error.

  an example:

  curl -g -i -X POST http://10.3.150.25/identity/v3/OS-TRUST/trusts -H
  "User-Agent: python-keystoneclient" -H "Content-Type:
  application/json" -H "Accept: application/json" -H "X-Auth-Token:
  gAAAAABaF5Odiawpf1t9BAAhyS3_FBZCKDPycpOnSndiC0TEmqemZvnINxcTPHLGR0J3mnjf60TdqIpct7SgO5movr5uWY-
  hmTT4R2Sr_5rYOPC_-w0y6XWbNn265U5IKVz0qMRr-
  1VagtuA3iPmyZkjCbFweZsP8yFkwWSxkY4_I0U6JTPzllM" -d '{"trust":
  {"impersonation": false, "project_id":
  "d88a1e3ce2504a10a5340225b85a844c", "trustor_user_id":
  "f98b4cc01a554453a84fa4b9ccf5a1f0", "roles": [{"fake_key": "123"}],
  "trustee_user_id": "c8b34ea0d6d6406aae5993061de92e77"}}'

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1734244/+subscriptions