yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #69521
[Bug 1704260] Re: load-edit should be commonized
Reviewed: https://review.openstack.org/483810
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=876f80c4a81f7575879ee2eb91e13e086e61183f
Submitter: Zuul
Branch: master
commit 876f80c4a81f7575879ee2eb91e13e086e61183f
Author: Shu Muto <shu-mutou@xxxxxxxxxxxxx>
Date: Fri Jul 14 13:55:27 2017 +0900
Commonize load-edit directive
Codes for load-edit directive is placing under framework directory:
horizon/static/framework/widgets
But it has code inside for Instance creation workflow.
This should be commonized.
If load-edit will be commonized, we can use it for Key Pair importing,
Orchestration Template and Environment in stack creation.
Furthermore, plugins can use load-edit. e.g. cert file uploading in
Magnum UI, cluster spec yaml registering in Senlin Dashboard, etc.
This patch fixes the issue.
Also, at the point view from UX, file input element should be
above of textarea. Because user wants to load file at first,
rather than input directly.
Change-Id: I3e1befb81996841820111558adf3ca386709904d
Closes-Bug: #1704260
** Changed in: horizon
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1704260
Title:
load-edit should be commonized
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
load-edit directive is placing under horizon/static/framework/widgets.
It should not have code for Instance creation workflow. If it will be
commonized, we can use it for Key Pair importing, Orchestration
Template and Environment in stack creation.
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1704260/+subscriptions
References