yahoo-eng-team team mailing list archive

[OpenStack Infra <1732830@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/521411
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=d48c8419ee73de275963f448a6718ff75f90a589
Submitter: Zuul
Branch:    master

commit d48c8419ee73de275963f448a6718ff75f90a589
Author: Abhishek Kekane <akekane@xxxxxxxxxx>
Date:   Mon Nov 20 03:44:23 2017 +0000

    Utilize LimitingReader for staging data
    
    ImageSizeLimitExceeded exception block is unreachable in stage
    call because glance is using sotre_backend.add (filesystem.add
    in this case) and it will raise 'exceptions.StorageFull()' [1]
    if image file is too large (errno.EFBIG).
    
    Used LimitingReader to enforce the image size limitation which
    will raise ImageSizeLimitExceeded if image size is larger that
    config option 'image_size_cap'.
    
    [1] https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/filesystem.py#L691
    
    Change-Id: I50821111ac4c782966ed1ccd48e92f8dd4100e62
    Closes-Bug: #1732830


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1732830

Title:
  Unreachable 'ImageSizeLimitExceeded' exception block in stage call

Status in Glance:
  Fix Released

Bug description:
  ImageSizeLimitExceeded exception block [1] is unreachable in stage because
  we are using sotre_backend.add (filesystem.add in this case) and it will
  raise 'exceptions.StorageFull()' [2] if image file is too large (errno.EFBIG).

  [1] https://github.com/openstack/glance/blob/master/glance/api/v2/image_data.py#L323
  [2] https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/filesystem.py#L691

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1732830/+subscriptions