yahoo-eng-team team mailing list archive

[OpenStack Infra <1733886@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/523194
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9ddbaa15cb55d1245a8a63d9414d134746fc2f3c
Submitter: Zuul
Branch:    master

commit 9ddbaa15cb55d1245a8a63d9414d134746fc2f3c
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Mon Nov 27 13:48:13 2017 -0500

    Fix 'force' parameter in os-quota-sets PUT schema
    
    A regression was introduced in the 2.36 API microversion where the
    'force' parameter was missing from the 'PUT /os-quota-sets/{tenant_id}'
    API request schema so users could not force quota updates with
    microversion 2.36 or later. The bug is now fixed so that the 'force'
    parameter can once again be specified during quota updates. There is
    no new microversion for this change since it is an admin-only API.
    
    Change-Id: I947e927802f755ccb25a91efd82cac895779d19e
    Closes-Bug: #1733886


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1733886

Title:
  'force' parameter broken in os-quota-sets microversion >= 2.36

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) newton series:
  In Progress
Status in OpenStack Compute (nova) ocata series:
  In Progress
Status in OpenStack Compute (nova) pike series:
  In Progress

Bug description:
  The 2.36 microversion broke the 'force' parameter in the os-quota-sets
  API:

  https://developer.openstack.org/api-ref/compute/#update-quotas

  It's because for 2.36 the schema redefined the properties but didn't
  copy the force parameter:

  https://github.com/openstack/nova/blob/f69d98ea744bc13189b17ba4c67e4f0279d2f45a/nova/api/openstack/compute/schemas/quota_sets.py#L47

  We could fix this as part of blueprint deprecate-file-injection which
  needs to change the os-quota-sets API to remove the injected_file*
  parameters, however, after the counting quotas changes in Pike, the
  'force' parameter doesn't really mean anything because there are no
  reserved quotas anymore, so maybe we just document this in the API
  reference and not try to 'fix it' since the fix wouldn't do anything.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1733886/+subscriptions