← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1732543] Re: HA network tenant network fails upon router delete

 

Reviewed:  https://review.openstack.org/475955
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=eaf7e65469d38156b2a38f62cf75d9f8015aaa0c
Submitter: Zuul
Branch:    master

commit eaf7e65469d38156b2a38f62cf75d9f8015aaa0c
Author: Miguel Lavalle <malavall@xxxxxxxxxx>
Date:   Tue Jun 20 23:25:24 2017 +0000

    Move segment deletion back to PRECOMMIT_DELETE
    
    This essentially reverts commit 12d24abba75ab3b926edbac389437bacc23914dd.
    
    Making the callback _delete_segments_for_network respond to
    BEFORE_DELETE network event has created some bugs. In one of them,
    it is not possible to delete a routed network, because the segments
    cannot be deleted due to the fact that the associated subnets still
    exist.
    
    Making _delete_segments_for_network respond to PRECOMMIT_DELETE
    introduces a StaleDataError with the standard attributes of the
    deleted segments. To work around that, network_db is expired and
    read again after notifying the PRECOMMIT_DELETE event in
    delete_network in the DB core plug-in.
    
    This also fixes an issue where we could delete the segment ID
    of the l3-ha network when deleting a router, leaving all other
    routers non-functioning.  Moving this to PRECOMMIT_DELETE fixes
    it since it is done after we have checked that the network is
    not in use and can be deleted.
    
    Closes-Bug: #1697324
    Closes-Bug: #1732543
    
    Change-Id: I7c3c4654f183b317647a28d599a538fe460db68f


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1732543

Title:
  HA network tenant network fails upon router delete

Status in neutron:
  Fix Released

Bug description:
  Openstack version: Pike
  Openvswitch version: 2.7

  Let's say I have a Openstack project where I've created 2 routers (R1
  & R2). Both routers are configured as L3-HA on pair of network nodes.
  Each of the 2 routers has an Active and a Passive namespace on each
  network node. Neutron creates a unique HA network for each project
  that allows the Active router to send VRRP messages to the Passive
  router. When using vxlan for the "tenant_network_type" a vxlan vni is
  assigned to the said HA network that allows that VRRP east/west
  traffic make it between the 2 network nodes.

  The assigned vni is discovered using "openstack network show UUID"

  Now, if we delete, for example, router R2, R1 will still need the HA
  network with its associated vni so VRRP communication can continue to
  work. The nature of this discovered bug is that if 1 router (either R1
  or R2, doesn't matter) is deleted the vni gets removed from a HA
  network entirely. At this point, the remaining router (R1) will
  continue to work, despite the HA network not functioning any more.

  After the network nodes get restarted though, the broken config is
  loaded and the routers cease to function per the HA network lacking a
  vni assignment.

  This problem didn't start happening until we upgraded to Pike.

  See attached for proposed fix.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1732543/+subscriptions


References