yahoo-eng-team team mailing list archive

[OpenStack Infra <1737558@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/527156
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=84216cb0f55481742340fab0f835407eefcb47fd
Submitter: Zuul
Branch:    master

commit 84216cb0f55481742340fab0f835407eefcb47fd
Author: Akihiro Motoki <amotoki@xxxxxxxxx>
Date:   Tue Dec 12 01:37:04 2017 +0900

    Always display server description
    
    The description field is only shown when the description of
    a corresponding server has non-empty string. It is better to
    display "description" field regardless of its value.
    
    "description" field is supported since Mitaka release, so
    this commit always shows 'description' field rather than
    showing the field conditionally.
    
    Change-Id: I2064c6e8a625d4362ce00218528a09ef734087fc
    Closes-Bug: #1737558


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1737558

Title:
  instance description is shown only when it has a value

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  In the instance detail page, the description field is only shown when
  the description of a corresponding server has non-empty string. It is
  better to display "description" field regardless of its value.

  [detail]
  Nova API returns 'null' (python None) for description field if no description is set for the server.
  The current _detail_overview.html checks {% if instance.description != None %} but it leads to a confused situation.

  I guess this was introduced to support an older nova APi version
  without description support, but there is no good way to distinguish
  no description field and empty description. There is also no good way
  to handle False and None separately in django template filter (without
  creating a new attribute like has_description). Having a new attribute
  like has_description works but I think it is too much, and the recent
  releases of nova support description field, so no check looks needed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1737558/+subscriptions