yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #69844
[Bug 1722417] Re: [Performance] Useless network API calls on instance panel
Reviewed: https://review.openstack.org/510718
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a42f58de50c84235f649d957ac925780d365e3db
Submitter: Zuul
Branch: master
commit a42f58de50c84235f649d957ac925780d365e3db
Author: Feilong Wang <flwang@xxxxxxxxxxxxxxx>
Date: Tue Oct 10 14:30:03 2017 +1300
Allow to skip API calls to Neutron in instance tables
Now instance panel is sending API calls to Neutron to get the addresses
info about network. It take some time until Nova network info cache is
synced when IP address operation like floating IP association is made
in Neutron. The API calls to Neutron exist from this reason.
However, it retrieves a full list of port, so it can potentially leads
to performance issues in large deployments. This commit adds a setting
flag to control whether API calls to Neutron is used or skipped in
the project instance table.
This commits drops a call of servers_update_addresses() in the admin
instance table. In the admin instance table there is no need to retrieve
IP addresses from neutron because the main purpose of the admin panel is
to see all instances and IP addresses in nova network info cache will be
synced soon.
Closes-Bug: #1722417
Co-Authored-By: Akihiro Motoki <amotoki@xxxxxxxxx>
Change-Id: Ie16784eb6352f70ab644dc8b6ea03fc6a881d3f9
** Changed in: horizon
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1722417
Title:
[Performance] Useless network API calls on instance panel
Status in OpenStack Dashboard (Horizon):
Fix Released
Bug description:
The function calling at https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/views.py#L95 is useless because Horizon is using the detailed API to get server list, see https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L529
With detailed API, the addresses of server are returned. So there is no need to call Neutron API to get the addresses info.
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1722417/+subscriptions
References