yahoo-eng-team team mailing list archive

[OpenStack Infra <1738612@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/528535
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e3488f451ecf6e76ccbd001255fcd7f5e8d48b37
Submitter: Zuul
Branch:    master

commit e3488f451ecf6e76ccbd001255fcd7f5e8d48b37
Author: Gary Kotton <gkotton@xxxxxxxxxx>
Date:   Sun Dec 17 01:12:34 2017 -0800

    Ensure floating IP create does not break
    
    Commit 088e317cd2dd8488feb29a4fa6600227d1810479 breaks floating IP
    creation.
    
    This changed the API and mandated that 'subnet_id' and
    'floating_ip_address' be passed in the API.
    
    This also cleans up tests with invalid inputs.
    
    Change-Id: I7bc758eed56610c269485681f67a5379730d8ef5
    Closes-Bug: #1738612


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1738612

Title:
  Floating IP update breakes decomposed plugins

Status in neutron:
  Fix Released

Bug description:
  Commit 088e317cd2dd8488feb29a4fa6600227d1810479 breaks dynamic
  routing:

  ft1.14: neutron_dynamic_routing.tests.unit.db.test_bgp_db.Ml2BgpTests.test__get_routes_by_router_with_fip_StringException: Traceback (most recent call last):
    File "/home/zuul/src/git.openstack.org/openstack/neutron/neutron/tests/base.py", line 132, in func
      return f(self, *args, **kwargs)
    File "neutron_dynamic_routing/tests/unit/db/test_bgp_db.py", line 780, in test__get_routes_by_router_with_fip
      fip = self.l3plugin.create_floatingip(self.context, fip_data)
    File "/home/zuul/src/git.openstack.org/openstack/neutron/neutron/db/api.py", line 162, in wrapped
      return method(*args, **kwargs)
    File "/home/zuul/src/git.openstack.org/openstack/neutron/neutron/db/api.py", line 92, in wrapped
      setattr(e, '_RETRY_EXCEEDED', True)
    File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__
      self.force_reraise()
    File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise
      six.reraise(self.type_, self.value, self.tb)
    File "/home/zuul/src/git.openstack.org/openstack/neutron/neutron/db/api.py", line 88, in wrapped
      return f(*args, **kwargs)
    File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/py27/local/lib/python2.7/site-packages/oslo_db/api.py", line 147, in wrapper
      ectxt.value = e.inner_exc
    File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__
      self.force_reraise()
    File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise
      six.reraise(self.type_, self.value, self.tb)
    File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/py27/local/lib/python2.7/site-packages/oslo_db/api.py", line 135, in wrapper
      return f(*args, **kwargs)
    File "/home/zuul/src/git.openstack.org/openstack/neutron/neutron/db/api.py", line 127, in wrapped
      LOG.debug("Retry wrapper got retriable exception: %s", e)
    File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 220, in __exit__
      self.force_reraise()
    File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 196, in force_reraise
      six.reraise(self.type_, self.value, self.tb)
    File "/home/zuul/src/git.openstack.org/openstack/neutron/neutron/db/api.py", line 123, in wrapped
      return f(*dup_args, **dup_kwargs)
    File "/home/zuul/src/git.openstack.org/openstack/neutron/neutron/db/l3_dvr_db.py", line 995, in create_floatingip
      context, floatingip, initial_status)
    File "/home/zuul/src/git.openstack.org/openstack/neutron/neutron/db/l3_db.py", line 1290, in _create_floatingip
      if fip['subnet_id']:
  KeyError: 'subnet_id'

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1738612/+subscriptions