yahoo-eng-team team mailing list archive

[OpenStack Infra <1738328@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/528675
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=154ddab1d4e1dfb46177027f7285ec4c92430966
Submitter: Zuul
Branch:    master

commit 154ddab1d4e1dfb46177027f7285ec4c92430966
Author: Ahmed Zaid <ahmed.zaid@xxxxxxxx>
Date:   Mon Dec 18 04:34:07 2017 -0500

    Drop flavor name validation in horizon side.
    
    This patch drop name validation in horizon and
    let nova check if the is name is valid or not.
    Instead of using pattern in the flavors form,
    pattern will be checked in the nova. Also I
    added limation for the name size with tests to
    check the max size since the min size has it's unit
    test.
    
    Closes-Bug: 1738328
    Change-Id: Ib4f6f9b87560df43819d992254603e55ea8ff6a3


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1738328

Title:
  Cannot specify "#" as name of a flavor

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  I ran following command with a master of devstack:

  stack@indoh-test:~/devstack$ openstack flavor create --ram 2048 --disk 10 --vcpus 1 "#1"
  +----------------------------+--------------------------------------+
  | Field                      | Value                                |
  +----------------------------+--------------------------------------+
  | OS-FLV-DISABLED:disabled   | False                                |
  | OS-FLV-EXT-DATA:ephemeral  | 0                                    |
  | disk                       | 10                                   |
  | id                         | 308fccc5-b8ff-4435-b022-29b3422ff5f4 |
  | name                       | #1                                   |
  | os-flavor-access:is_public | True                                 |
  | properties                 |                                      |
  | ram                        | 2048                                 |
  | rxtx_factor                | 1.0                                  |
  | swap                       |                                      |
  | vcpus                      | 1                                    |
  +----------------------------+--------------------------------------+

  stack@indoh-test:~/devstack$ openstack flavor list
  +--------------------------------------+-----------+-------+------+-----------+-------+-----------+
  | ID                                   | Name      |   RAM | Disk | Ephemeral | VCPUs | Is Public |
  +--------------------------------------+-----------+-------+------+-----------+-------+-----------+
  | 1                                    | m1.tiny   |   512 |    1 |         0 |     1 | True      |
  | 2                                    | m1.small  |  2048 |   20 |         0 |     1 | True      |
  | 3                                    | m1.medium |  4096 |   40 |         0 |     2 | True      |
  | 308fccc5-b8ff-4435-b022-29b3422ff5f4 | #1        |  2048 |   10 |         0 |     1 | True      |
  | 4                                    | m1.large  |  8192 |   80 |         0 |     4 | True      |
  | 5                                    | m1.xlarge | 16384 |  160 |         0 |     8 | True      |
  | c1                                   | cirros256 |   256 |    0 |         0 |     1 | True      |
  | d1                                   | ds512M    |   512 |    5 |         0 |     1 | True      |
  | d2                                   | ds1G      |  1024 |   10 |         0 |     1 | True      |
  | d3                                   | ds2G      |  2048 |   10 |         0 |     2 | True      |
  | d4                                   | ds4G      |  4096 |   20 |         0 |     4 | True      |
  +--------------------------------------+-----------+-------+------+-----------+-------+-----------+

  However, we couldn't create the flavor which includes "#" as 'name' of
  flavor.  Please refer attached an image.  I think it should be aligned
  with CLI behavior.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1738328/+subscriptions