yahoo-eng-team team mailing list archive

[OpenStack Infra <1676877@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/456773
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a9aef9b9c726ccf42c204bcd9a8b86a8c9404723
Submitter: Zuul
Branch:    master

commit a9aef9b9c726ccf42c204bcd9a8b86a8c9404723
Author: Reedip <reedip.banerjee@xxxxxxxxxxxxxxxxxx>
Date:   Wed May 24 03:48:28 2017 +0000

    Improve Qos Policy Rule test
    
    The current policy rule tests do not test the actual
    rule information involved in the test.
    This patch takes care of the same.
    
    
    Closes-Bug: 1676877
    Change-Id: I50ccb9e9237f7e3b2f5c66d1fc3b539905fa0281


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1676877

Title:
  Increase "TestQosPlugin.test_update_policy_rule"  coverage

Status in neutron:
  Fix Released

Bug description:
  Test "test_update_policy_rule" [1] is not fully testing the functionality of the function under test, for several reasons:
  - The test is not testing the QoS policy object has the rule updated. In [2], the QoS policy reload the rules by requesting from the DB the new rule objects and then writing the result to "rules" member. [3] should be mocked to return the correct values (updated rules).
  - The test is updating the rule value with the same content. At least there should be a change in the content to check the difference.
  - Function "_validate_driver_params" should check not only the last parameter in the notification driver and the service notification call is a QosPolicy object, but also the content of the parameter.
  - Test precommit calls.

  [1] https://github.com/openstack/neutron/blob/master/neutron/tests/unit/services/qos/test_qos_plugin.py#L155
  [2] https://github.com/openstack/neutron/blob/master/neutron/services/qos/qos_plugin.py#L94
  [3] https://github.com/openstack/neutron/blob/master/neutron/objects/qos/policy.py#L80

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1676877/+subscriptions