← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1719714] Re: Excessive logging of "We're on a Pike compute host in a deployment with all Pike compute hosts."

 

Reviewed:  https://review.openstack.org/508262
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=895e3be3fee74bf71a80e9ccad482fdd408fa42f
Submitter: Zuul
Branch:    master

commit 895e3be3fee74bf71a80e9ccad482fdd408fa42f
Author: Jan Zerebecki <jan.openstack@xxxxxxxxxxxx>
Date:   Thu Sep 28 18:36:15 2017 +0200

    Only log not correcting allocation once per period
    
    Logging once per instance per periodic task run that nothing was done,
    because it is already correct, is unnecessary.
    
    Fix the wording of the debug messages, to be correct after future
    releases and account for the ironic driver requesting the same
    behaviour.
    
    Closes-Bug: 1719714
    Change-Id: Id68b68c261efbe4f18d2fb15cb08240866e22466


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1719714

Title:
  Excessive logging of "We're on a Pike compute host in a deployment
  with all Pike compute hosts."

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) pike series:
  In Progress

Bug description:
  There are two issues with this log message from the resource tracker:

  Sep 26 18:44:37 devstack nova-compute[30351]: DEBUG
  nova.compute.resource_tracker [None req-992d494e-d328-4204-bcfe-
  80d926cf0a65 demo demo] We're on a Pike compute host in a deployment
  with all Pike compute hosts. Skipping auto-correction of allocations.
  {{(pid=30351) _update_usage_from_instance
  /opt/stack/nova/nova/compute/resource_tracker.py:1071}}

  1. If you're in Queens, you don't have Pike compute hosts. So the
  message is misleading.

  2. The message gets logged once per instance on a given compute host
  every minute when the update_instance_allocation periodic task runs.

  We should fix the message in #1 to say something else than Pike
  specifically, and fix #2 to only log that once per periodic, rather
  than once per instance per periodic.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1719714/+subscriptions


References