yahoo-eng-team team mailing list archive

[OpenStack Infra <1739013@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/529063
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ec040527368a13cdc5ed427b21692be5bb2f28b6
Submitter: Zuul
Branch:    master

commit ec040527368a13cdc5ed427b21692be5bb2f28b6
Author: Balazs Gibizer <balazs.gibizer@xxxxxxxxxxxx>
Date:   Tue Dec 19 14:21:32 2017 +0100

    Fix false positive server group functional tests
    
    Most of the evacuate tests in nova.tests.functional.test_server_group
    could produce false positive results becuase of multiple reasons:
    * test did not wait for the migration to finish in done or error state
      before checked the instance host
    * test did not asserted that the instance host is changed during the
      evacuation
    
    Also the evacuation tests that starts up a third compute failed to add
    the magic fake.set_nodes() call making the third node unusable and
    causing unexpected NoValidHost during the evacuation. However it was
    not visible until the above mistakes are fixed in the test
    
    Change-Id: Idc4e3d8ac7c99c09c6f4860dc0c7a05f28a35627
    Closes-Bug: #1739013


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1739013

Title:
  nova.tests.functional.test_server_group.ServerGroupTest*.test_evacuate_with_anti_affinity
  does not  validate that evacuation really happens

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The tests only asserts that the policy is kept after the evacuation
  API is called [1] but does not check if the evacuated server is moved
  to a new host. When I added those asserts locally it become clear that
  the evacuation fails with NoValidHost but the test passes causing a
  false positive result.

  The logs in those failed tests show multiple potential problems [2].

  [1] https://github.com/openstack/nova/blob/42d2c0263edf9041b7e97b0b59982dcfe904a137/nova/tests/functional/test_server_group.py#L431
  [2] http://paste.openstack.org/show/629301/

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1739013/+subscriptions