yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #70259
[Bug 1741125] Re: Instance resize intermittently fails when rescheduling
Reviewed: https://review.openstack.org/531022
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=db711bc06fcc234488b107dd22dd2a0272939174
Submitter: Zuul
Branch: master
commit db711bc06fcc234488b107dd22dd2a0272939174
Author: Ed Leafe <ed@xxxxxxxxx>
Date: Wed Jan 3 21:38:43 2018 +0000
Fix race condition in retrying migrations
During testing in the alternate host series, it was found that retries
when resizing an instance would always fail. This turned out to be true
even before alternate hosts for resize was introduced. Further
investigation showed that there was a race in call to retry the resize
and the revert of the original attempt.
This patch fixes that race condition, and updates the regression test to
reflect the correct results.
Blueprint: return-alternate-hosts
Closes-Bug #1741125
Change-Id: I12b4e1d9e50fefd81128df85d75bb34564f9da2c
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1741125
Title:
Instance resize intermittently fails when rescheduling
Status in OpenStack Compute (nova):
Fix Released
Bug description:
When resizing an instance, the migration task calls "replace_allocation_with_migration()', which checks to verify that the instance has allocations against the source compute node [0]. It then replaces the instance's allocation with the migration, using it's UUID as the consumer instead of the instance's. However, if the first attempt at migrating fails and the resize is rescheduled, when "replace_allocation_with_migration()" is called again, the allocations now have the migration UUID as the consumer, and so the check that the instance has allocations on the source compute node will fail, and the migration is put in an ERROR state.
[0] https://github.com/openstack/nova/blob/f95f165b49fbc0efe29450b0e858a3ccadecedea/nova/conductor/tasks/migrate.py#L47-L48
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1741125/+subscriptions
References