yahoo-eng-team team mailing list archive

[OpenStack Infra <1737892@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/533318
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a8271e978a1c540ae9888f568cf14b4c40ea1b6d
Submitter: Zuul
Branch:    master

commit a8271e978a1c540ae9888f568cf14b4c40ea1b6d
Author: Sławek Kapłoński <slawek@xxxxxxxxxxxx>
Date:   Fri Jan 12 23:08:56 2018 +0100

    [OVS] Fix for cleaning after skipped_devices
    
    When Openvswitch agent will get "port_update" event
    (e.g. to set port as unbound) and port is already removed
    from br-int when agent tries to get vif port in
    treat_devices_added_updated() method (port is removed
    because e.g. nova-compute removes it) then resources set
    for port by L2 agent extension drivers (like qos) are not
    cleaned properly.
    
    In such case port is added to skipped_ports and is set
    as DOWN in neutron-db but ext_manager is not called then
    for such port so it will not clear stuff like bandwidth
    limit's QoS and queue records and also DSCP marking
    open flow rules for this port.
    
    This patch fixes this issue by adding call of
    ext_manager.delete_port() method for all skipped ports.
    
    Change-Id: I3cf5c57c7f232deaa190ab6b0129e398fdabe592
    Closes-Bug: #1737892


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1737892

Title:
  Fullstack test
  test_qos.TestBwLimitQoSOvs.test_bw_limit_qos_port_removed failing many
  times

Status in neutron:
  Fix Released

Bug description:
  It looks that this test fails every time with same reason:

  2017-12-13 05:29:35.846 | Captured traceback:
  2017-12-13 05:29:35.848 | ~~~~~~~~~~~~~~~~~~~
  2017-12-13 05:29:35.850 |     Traceback (most recent call last):
  2017-12-13 05:29:35.852 |       File "neutron/tests/base.py", line 132, in func
  2017-12-13 05:29:35.854 |         return f(self, *args, **kwargs)
  2017-12-13 05:29:35.856 |       File "neutron/tests/fullstack/test_qos.py", line 237, in test_bw_limit_qos_port_removed
  2017-12-13 05:29:35.858 |         self._wait_for_bw_rule_removed(vm, self.direction)
  2017-12-13 05:29:35.860 |       File "neutron/tests/fullstack/test_qos.py", line 121, in _wait_for_bw_rule_removed
  2017-12-13 05:29:35.862 |         self._wait_for_bw_rule_applied(vm, None, None, direction)
  2017-12-13 05:29:35.864 |       File "neutron/tests/fullstack/test_qos.py", line 219, in _wait_for_bw_rule_applied
  2017-12-13 05:29:35.866 |         lambda: vm.bridge.get_ingress_bw_limit_for_port(
  2017-12-13 05:29:35.868 |       File "neutron/common/utils.py", line 632, in wait_until_true
  2017-12-13 05:35:14.907 |         raise WaitTimeout("Timed out after %d seconds" % timeout)
  2017-12-13 05:35:14.909 |     neutron.common.utils.WaitTimeout: Timed out after 60 seconds

  Example fail: http://logs.openstack.org/73/519573/12/check/legacy-
  neutron-dsvm-fullstack/f27cbf9/logs/devstack-gate-
  post_test_hook.txt#_2017-12-13_05_29_35_842

  It failed 16 times in 24h between 9:00 12.12.2017 and 9:00 13.12.2017:
  http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22neutron.tests.fullstack.test_qos.TestBwLimitQoSOvs.test_bw_limit_qos_port_removed%5C%22%20AND%20message%3A%5C%22FAILED%5C%22

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1737892/+subscriptions