← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1733207] Re: BatchAction displays error messages twice

 

Reviewed:  https://review.openstack.org/521384
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3e8088b80067c480b3b3aba0a8d2caf02dfb5672
Submitter: Zuul
Branch:    master

commit 3e8088b80067c480b3b3aba0a8d2caf02dfb5672
Author: Akihiro Motoki <amotoki@xxxxxxxxx>
Date:   Sun Nov 19 20:46:44 2017 +0000

    Improve exception message in network related Batch/DeleteAction
    
    DeleteActiona and BatchAction in the network, subnet and router tables
    are improved using handle_exception_with_detail_message decorator.
    
    There is no need to have separate delete action in the admin network
    and subnet tables now, so they are merged into the corresponding delete
    actions in the project tables.
    
    Change-Id: I976e4e6ed8e9c1430f82ac362c080853744b5d07
    Closes-Bug: #1733207


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1733207

Title:
  BatchAction displays error messages twice

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  If action() in BatchAction displays an error message to describe some detail reason of a failure, a user will get multiple error messages: the detail error message and "Unable to <action> <object>".
  This is because BatchAction handle() always tries to display error message. We need more smart error message handling.

  On the other hand, if there is no need to display a detail error
  message in action() of individual BatchAction instance, try/except
  should not be used.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1733207/+subscriptions


References