yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #70722
[Bug 1744688] Re: api-ref: wrong parameter type in server-migrations.inc
Reviewed: https://review.openstack.org/536293
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=312327b75989fe0aad209c56671c583e33709303
Submitter: Zuul
Branch: master
commit 312327b75989fe0aad209c56671c583e33709303
Author: Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>
Date: Mon Jan 22 19:01:00 2018 +0900
api-ref: Fix parameter type in server-migrations.inc
When the parameter is always 'null', it should be defined as 'none'.
So fix the parameter type of the 'force_complete'
in "Force Migration Complete Action" API.
And add an additional description for the action.
Change-Id: Ic0dd390a87d0d5a88d9a08fdaa9e59ee99f6e7c4
Closes-Bug: #1744688
** Changed in: nova
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1744688
Title:
api-ref: wrong parameter type in server-migrations.inc
Status in OpenStack Compute (nova):
Fix Released
Bug description:
In "Force Migration Complete Action" API(*1), the 'force_complete' parameter in the request is defined as 'string'.
This parameter is always 'null'(*2).
In the other APIs, it is defined as 'none' (e.g. "Start Server" API (*3)) in that case.
So It should be 'none' as well in "Force Migration Complete Action" API.
*1: https://developer.openstack.org/api-ref/compute/#force-migration-complete-action-force-complete-action
*2: https://github.com/openstack/nova/blob/a40c00957ef4552681c172913bae1135a1614bbc/nova/api/openstack/compute/schemas/server_migrations.py#L21
*3: https://developer.openstack.org/api-ref/compute/#start-server-os-start-action
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1744688/+subscriptions
References