yahoo-eng-team team mailing list archive

[Eric Berglund <esberglu@xxxxxxxxxx>]

Public bug reported:

When accessing the capabilities dict [1], nova should be using
dict.get(). Since many compute drivers override the capabilities
dictionary,

capabilites['capability']

will fail with a KeyError if their dictionary has not been updated to
include the capability. By using get() it will default instead of
throwing the KeyError.

[1]
https://github.com/openstack/nova/blob/5251f18d87/nova/virt/driver.py#L124-L134

** Affects: nova
     Importance: Undecided
     Assignee: Eric Berglund (esberglu)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => Eric Berglund (esberglu)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1746608

Title:
  Nova not always using get to access driver capabilites dict

Status in OpenStack Compute (nova):
  New

Bug description:
  When accessing the capabilities dict [1], nova should be using
  dict.get(). Since many compute drivers override the capabilities
  dictionary,

  capabilites['capability']

  will fail with a KeyError if their dictionary has not been updated to
  include the capability. By using get() it will default instead of
  throwing the KeyError.

  [1]
  https://github.com/openstack/nova/blob/5251f18d87/nova/virt/driver.py#L124-L134

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1746608/+subscriptions