yahoo-eng-team team mailing list archive

[OpenStack Infra <1734025@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/522112
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ca6daf148debb9c9646fcf6db9660c830da5a594
Submitter: Zuul
Branch:    master

commit ca6daf148debb9c9646fcf6db9660c830da5a594
Author: lixipeng <lixipeng@xxxxxxxxxxxxx>
Date:   Wed Nov 22 12:03:58 2017 +0800

    Fix bug case by none token context
    
    When set reclaim_instance_interval > 0, and then delete an
    instance which booted from volume with `delete_on_termination`
    set as true. After reclaim_instance_interval time pass,
    all volumes boot instance will with state: attached and in-use,
    but attached instances was deleted.
    
    This bug case as admin context from
    `nova.compute.manager._reclaim_queued_deletes` did not have
    any token info, then call cinder api would be failed.
    
    So add user/project CONF with admin role at cinder group,
    and when determine context is_admin and without token, do
    authenticaion with user/project info to call cinder api.
    
    Change-Id: I3c35bba43fee81baebe8261f546c1424ce3a3383
    Closes-Bug: #1733736
    Closes-Bug: #1734025
    Partial-Bug: #1736773


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1734025

Title:
  cleanup running deleted instance with reap failed with none token
  context

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Description

  When zombied instances appear(You can also see bug https://bugs.launchpad.net/nova/+bug/911366),
  set running_deleted_instance_poll_interval = 60 and running_deleted_instance_action = reap, then nova-compute service will clear those zombied instances, but if those instances is boot from volume or had volumes attached. After clear, zombied instances cleared, but volumes with attached status exist, and if those volumes are bootable and used to boot volume and set deleted_on_termination=True, thoses volume will still exist and in attached status but instance did not exist.

  Steps to reproduce

  1. set running_deleted_instance_poll_interval=60 and running_deleted_instance_action = reap.
  2. update an running instance status to deleted.
  3. restart nova-compute service and wait 60 seconds.

  Expected result

  Previous test bootable volume was deleted and volumes attached to
  zombied instances ware detached.

  Actual result

  Previous test bootable volume was in state attached and in-use,
  volumes attached to zombied instances ware in-use and attached to
  those zombied instances.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1734025/+subscriptions