yahoo-eng-team team mailing list archive

[OpenStack Infra <1606647@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/539254
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1278f2dc11e83618dc9932b7fe80d6b84517ccdd
Submitter: Zuul
Branch:    master

commit 1278f2dc11e83618dc9932b7fe80d6b84517ccdd
Author: Ed Leafe <ed@xxxxxxxxx>
Date:   Thu Jan 11 17:58:15 2018 +0000

    Fix invalid UUIDs in remaining tests
    
    There were many places throughout our tests that used plain strings
    where the object was expecting a UUID, which caused lots of warning
    output when running the tests. This patch replaces all such usages with
    proper UUIDs.
    
    Closes-Bug: #1606647
    
    Change-Id: Ib339b97ef178c870405e19385d3df24dd1f730cc


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1606647

Title:
  Invalid UUIDs during tests

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  In many places, wrong fake UUID is used. We should get rid of them.
  Except nova_manage which uses the markers, and UUIDs the wrong way, so
  we cannot removed that one (this time).

  During testint (e.g.: tox -epy27), lot of warnings get created in the log.
  Some examples, which we should remove:

  {6}
  nova.tests.unit.compute.test_compute_mgr.ComputeManagerUnitTestCase.test_check_device_tagging_tagged_net_req_no_virt_support
  [0.157444s] ... ok

  Captured stderr:
  ~~~~~~~~~~~~~~~~
      /home/user/nova/nova/.tox/py27/local/lib/python2.7/site-packages/oslo_versionedobjects/fields.py:348: FutureWarning: bar is an invalid UUID. Using UUIDFields with invalid UUIDs is no longer supported, and will be removed in a future release. Please update your code to input valid UUIDs or accept ValueErrors for invalid UUIDs. See http://docs.openstack.org/developer/oslo.versionedobjects/api/fields.html#oslo_versionedobjects.fields.UUIDField for further details
        "for further details" % value, FutureWarning)
      

  {0}
  nova.tests.unit.network.test_neutronv2.TestNeutronv2.test_allocate_for_instance_not_enough_macs
  [0.135878s] ... ok

  Captured stderr:
  ~~~~~~~~~~~~~~~~
      /home/user/nova/nova/.tox/py27/local/lib/python2.7/site-packages/oslo_versionedobjects/fields.py:348: FutureWarning: fake is an invalid UUID. Using UUIDFields with invalid UUIDs is no longer supported, and will be removed in a future release. Please update your code to input valid UUIDs or accept ValueErrors for invalid UUIDs. See http://docs.openstack.org/developer/oslo.versionedobjects/api/fields.html#oslo_versionedobjects.fields.UUIDField for further details
        "for further details" % value, FutureWarning)

  {5}
  nova.tests.unit.network.test_neutronv2.TestNeutronv2.test_allocate_for_instance_with_externalnet_admin_ctx
  [0.139779s] ... ok

  Captured stderr:
  ~~~~~~~~~~~~~~~~
      /home/user/nova/nova/.tox/py27/local/lib/python2.7/site-packages/oslo_versionedobjects/fields.py:348: FutureWarning: fake is an invalid UUID. Using UUIDFields with invalid UUIDs is no longer supported, and will be removed in a future release. Please update your code to input valid UUIDs or accept ValueErrors for invalid UUIDs. See http://docs.openstack.org/developer/oslo.versionedobjects/api/fields.html#oslo_versionedobjects.fields.UUIDField for further details
        "for further details" % value, FutureWarning)


  But there are some warnings, which we can't remove easily. These are the markers in nova manage. 
  Some warnings, we cannot remove easily:
  nova.tests.unit.test_nova_manage.CellV2CommandsTestCase.test_map_instances_marker_deleted [0.652649s] ... ok

  Captured stderr:
  ~~~~~~~~~~~~~~~~
      /home/user/nova/nova/.tox/py27/local/lib/python2.7/site-packages/oslo_versionedobjects/fields.py:348: FutureWarning: 73e1b0e8 cb2f 460b 926d 547f1f24bfef is an invalid UUID. Using UUIDFields with invalid UUIDs is no longer supported, and will be removed in a future release. Please update your code to input valid UUIDs or accept ValueErrors for invalid UUIDs. See http://docs.openstack.org/developer/oslo.versionedobjects/api/fields.html#oslo_versionedobjects.fields.UUIDField for further details
        "for further details" % value, FutureWarning)

  {1}
  nova.tests.unit.test_nova_manage.CellV2CommandsTestCase.test_map_instances_max_count
  [0.515909s] ... ok

  Captured stderr:
  ~~~~~~~~~~~~~~~~
      /home/user/nova/nova/.tox/py27/local/lib/python2.7/site-packages/oslo_versionedobjects/fields.py:348: FutureWarning: ca009c24 21b8 471c 8ca7 1cc0981d97e5 is an invalid UUID. Using UUIDFields with invalid UUIDs is no longer supported, and will be removed in a future release. Please update your code to input valid UUIDs or accept ValueErrors for invalid UUIDs. See http://docs.openstack.org/developer/oslo.versionedobjects/api/fields.html#oslo_versionedobjects.fields.UUIDField for further details
        "for further details" % value, FutureWarning)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1606647/+subscriptions