yahoo-eng-team team mailing list archive

[Thomas Morin <1746996@xxxxxxxxxxxxxxxxxx>]

The issue we have seems to be related to the fact that this unit test mixes:
- old engine facade code from networking-bagpipe OVO code
- new engine facade code for IPAllocations

This issue is strongly related to bug 1744829 .

My current understanding is that:
- [2] resulted in the use of OVO for IPAllocations
- networking-bgpvpn then started to make use of OVO, resulting in IPAllocation in OVO objects construction (both old engine facade, so all good)
- when [1] merged to revert [2] because of bug 174829, IPAllocation went back to non-OVO, hence
using the new engine facade, while we still use OVO to query IPAllocations in networking-bagpipe OVO objects

[1] https://review.openstack.org/#/c/536913
[2] https://review.openstack.org/#/c/407868

** Also affects: networking-bagpipe
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1746996

Title:
  bagpipe: IPAllocation DB query failing, engine facade mismatch

Status in networking-bgpvpn:
  New
Status in BaGPipe:
  New
Status in neutron:
  New

Bug description:
  networking_bgpvpn.tests.unit.services.bagpipe.test_bagpipe.TestBagpipeServiceDriverV2RPCs.test_router_itf_event_network_assoc
  is currently failing

  Traceback (most recent call last):
    File "/home/teom7365/prog/openstack/networking-bgpvpn/networking_bgpvpn/neutron/services/service_drivers/bagpipe/bagpipe_v2.py", line 260, in registry_router_interface_before_delete
      context, router_id, network_id)
    File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/py27/local/lib/python2.7/site-packages/oslo_log/helpers.py", line 67, in wrapper
      return method(*args, **kwargs)
    File "/home/teom7365/prog/openstack/networking-bgpvpn/networking_bgpvpn/neutron/services/service_drivers/bagpipe/bagpipe_v2.py", line 218, in notify_router_interface_deleted
      network_id=net_id) +
    File "neutron/objects/base.py", line 561, in get_objects
      return [cls._load_object(context, db_obj) for db_obj in db_objs]
    File "neutron/objects/base.py", line 496, in _load_object
      obj.from_db_object(db_obj)
    File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/py27/src/networking-bagpipe/networking_bagpipe/objects/bgpvpn.py", line 156, in from_db_object
      self._load_subnets(obj)
    File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/py27/src/networking-bagpipe/networking_bagpipe/objects/bgpvpn.py", line 150, in _load_subnets
      subnets_info = _get_subnets_info(self.obj_context, self.network_id)
    File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/py27/src/networking-bagpipe/networking_bagpipe/objects/bgpvpn.py", line 62, in _get_subnets_info
      for subnet in subnets
    File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/py27/src/networking-bagpipe/networking_bagpipe/objects/bgpvpn.py", line 47, in _get_gateway_mac_by_subnet
      port = Port.get_object(obj_context, id=ip_allocation.port_id)
    File "neutron/objects/base.py", line 538, in get_object
      return cls._load_object(context, db_obj)
    File "neutron/objects/base.py", line 496, in _load_object
      obj.from_db_object(db_obj)
    File "neutron/objects/ports.py", line 409, in from_db_object
      super(Port, self).from_db_object(db_obj)
    File "neutron/objects/base.py", line 440, in from_db_object
      self.load_synthetic_db_fields(db_obj)
    File "neutron/objects/base.py", line 737, in load_synthetic_db_fields
      for obj in synth_db_objs]
    File "neutron/objects/base.py", line 498, in _load_object
      context.session.expunge(obj.db_obj)
    File "/home/teom7365/prog/openstack/networking-bgpvpn/.tox/py27/local/lib/python2.7/site-packages/sqlalchemy/orm/session.py", line 1650, in expunge
      state_str(state))
  InvalidRequestError: Instance <IPAllocation at 0x7f276b935910> is not present in this Session

  
  "git bisect" show that neutron commit 906eda44d2c230be99fc5c61daa0f359ab46a3ad [1] introduces the issue

  [1] https://review.openstack.org/#/c/536913/

To manage notifications about this bug go to:
https://bugs.launchpad.net/bgpvpn/+bug/1746996/+subscriptions