← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1747693] [NEW] boot from volume using source type blank/image/snapshot still does legacy style attach

 

Public bug reported:

As part of this blueprint in queens:

https://specs.openstack.org/openstack/nova-specs/specs/queens/approved
/cinder-new-attach-apis.html

We now want to create new volume attachments using the cinder 3.44 API.

However, when booting from volume using a source_type of
blank/image/snapshot, where nova-compute creates the volume and then
attaches it, it still goes down the legacy attach flow because a volume
attachment record is never created and stored on the
BlockDeviceMapping.attachment_id field.

There are even TODOs in the code for where this needs to be fixed:

https://github.com/openstack/nova/blob/2c1874a0ecdd1b5ce7670cdfc42396e90e3a55aa/nova/virt/block_device.py#L687

https://github.com/openstack/nova/blob/2c1874a0ecdd1b5ce7670cdfc42396e90e3a55aa/nova/virt/block_device.py#L712

https://github.com/openstack/nova/blob/2c1874a0ecdd1b5ce7670cdfc42396e90e3a55aa/nova/virt/block_device.py#L736

** Affects: nova
     Importance: Medium
     Assignee: Matt Riedemann (mriedem)
         Status: Triaged


** Tags: volumes

** Changed in: nova
     Assignee: (unassigned) => Matt Riedemann (mriedem)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1747693

Title:
  boot from volume using source type blank/image/snapshot still does
  legacy style attach

Status in OpenStack Compute (nova):
  Triaged

Bug description:
  As part of this blueprint in queens:

  https://specs.openstack.org/openstack/nova-specs/specs/queens/approved
  /cinder-new-attach-apis.html

  We now want to create new volume attachments using the cinder 3.44
  API.

  However, when booting from volume using a source_type of
  blank/image/snapshot, where nova-compute creates the volume and then
  attaches it, it still goes down the legacy attach flow because a
  volume attachment record is never created and stored on the
  BlockDeviceMapping.attachment_id field.

  There are even TODOs in the code for where this needs to be fixed:

  https://github.com/openstack/nova/blob/2c1874a0ecdd1b5ce7670cdfc42396e90e3a55aa/nova/virt/block_device.py#L687

  https://github.com/openstack/nova/blob/2c1874a0ecdd1b5ce7670cdfc42396e90e3a55aa/nova/virt/block_device.py#L712

  https://github.com/openstack/nova/blob/2c1874a0ecdd1b5ce7670cdfc42396e90e3a55aa/nova/virt/block_device.py#L736

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1747693/+subscriptions


Follow ups