yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #71095
[Bug 1748942] Re: Ironic virt driver should not JSON encode traits in instance_info
(1:29:28 PM) mgoddard: mriedem: the scheduling works, but any flavor-requested traits won't be pushed to the ironic node's instance_info. These are not yet used by ironic, but will be used in future for some capabilities-like things
(1:29:49 PM) mriedem: mgoddard: if they aren't used in ironic in queens, then it's not something worth holding up rc2 IMO
** Also affects: nova/queens
Importance: Undecided
Status: New
** Changed in: nova/queens
Status: New => Confirmed
** Changed in: nova/queens
Importance: Undecided => Low
** Changed in: nova
Importance: Undecided => Medium
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1748942
Title:
Ironic virt driver should not JSON encode traits in instance_info
Status in OpenStack Compute (nova):
In Progress
Status in OpenStack Compute (nova) queens series:
Confirmed
Bug description:
As of queens, the ironic virt driver pushes traits set on the flavor
to the ironic node's instance_info during instance spawn. This list of
traits is currently encoded as a JSON string, inside the JSON-encoded
instance_info. We should not use this double layer of JSON encoding,
as ironic expects instance_info.traits to be a list.
Steps to reproduce
==================
Add a trait to an ironic node:
openstack baremetal node add trait <node> <trait>
Add a required trait to a flavor:
openstack flavor set <flavor> --property 'trait:<trait>=required'
Create an instance using this flavor:
openstack server create ...
Expected result
===============
Nova sets the node's instance_info.traits to a list containing the
trait.
Actual result
=============
Nova sets the node's instance_info.traits to a JSON-encoded string
containing a list containing the trait.
Environment
===========
Nova stable/queens @ 01b756f960ed19ab801994d08d749dd94d729a22
To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1748942/+subscriptions
References