yahoo-eng-team team mailing list archive

[OpenStack Infra <1746526@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/539922
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a91d84cfb44a9def517f2990d164b4972023709a
Submitter: Zuul
Branch:    master

commit a91d84cfb44a9def517f2990d164b4972023709a
Author: Sławek Kapłoński <slawek@xxxxxxxxxxxx>
Date:   Thu Feb 1 12:59:02 2018 +0100

    Fix error message when duplicate QoS rule is created
    
    When user tries to create QoS rule which already exists in same
    QoS policy, only check if rule is duplicated was done on DB layer.
    Because of that, there was many retries of DB operations so user
    waits to response from Neutron server long time.
    Also error message returned from this DB related exception was not
    user friendly.
    
    This patch adds additional check of such duplicated rules before
    there is attempt to save new/updated rule in database so in case
    of error, response is send to user faster and it has proper
    message.
    
    Change-Id: I7d55df1eb931583c3dde064e073deb3e5479acc2
    Closes-Bug: #1746526


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1746526

Title:
  Incorrect message appears while creating duplicate qos-bandwidth-
  limit-rule

Status in neutron:
  Fix Released

Bug description:
  Improper error messages comes if user tries to create duplicate rule
  under qos-policy.

  In error message two things to correct:-
  --> attribute_name
  --> value

  $ neutron qos-bandwidth-limit-rule-create  --max-kbps 1026 <qos-policy-id>
  E.g.: neutron qos-bandwidth-limit-rule-create  --max-kbps 1026 f73cf8ea-92be-472d-aeef-3364319fc51e
  neutron CLI is deprecated and will be removed in the future. Use openstack CLI instead.
  Failed to create a duplicate QosBandwidthLimitRule: for attribute(s) ['qos_bandwidth_rules0qos_policy_id0direction'] with value(s) f73cf8ea-92be-472d-aeef-3364319fc51e-egress
  Neutron server returns request_ids: ['req-0447aa9e-acc0-4200-8ea7-5752edcab574']

  Steps:-
  1) Create qos-policy
     neutron qos-policy-create policy-1
  2) Create qos-bandwidth-limit-rule
      neutron qos-bandwidth-limit-rule-create --max-kbps 1026 policy-1
  3) Again create qos-bandwidth-limit-rule
     neutron qos-bandwidth-limit-rule-create --max-kbps 1026 policy-1

  Can we correct error message?

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1746526/+subscriptions