← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1748777] Re: Admin State is always UP regardless of whether Admin State is enabled or not

 

Reviewed:  https://review.openstack.org/543248
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0cb96af3a2a77628cd7c3147383ec7e220d49596
Submitter: Zuul
Branch:    master

commit 0cb96af3a2a77628cd7c3147383ec7e220d49596
Author: wei.ying <wei.ying@xxxxxxxxxxxx>
Date:   Mon Feb 12 01:44:26 2018 +0800

    Admin State is always UP whatever whether router Admin State is checked or not
    
    On the project creation router page, if we don't check "Enable Admin
    State" option, when the router is created, "Admin State" is displayed
    as UP. This inconsistency is because the judgment condition of [1]
    doesn't hold which causes the "admin_state_up" parameter not to be
    passed by the call creation router interface. In this case, the
    back-end defaults to "admin_state_up" to be UP.
    
    Since the router "Enable Admin State" option has an initial value of
    True, there is no need to check for [1].
    
    [1] https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/routers/forms.py#L121
    
    Change-Id: I6b95ffa680eab5c29d2bca6c91fc7f028f7f519a
    Closes-Bug:#1748777


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1748777

Title:
  Admin State is always UP regardless of whether Admin State is enabled
  or not

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Env: devstack master branch

  Steps to reproduce:
  1. Go to Porject/Routers panel.
  2. Click the "Create Router" button and Don't enable "Enable Admin State" option.
  3. Submit the form.

  After the router is created, we can see that the "Admin State" column
  is displayed as UP.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1748777/+subscriptions


References