← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1720322] Re: Unnecessary notification when notify_sg_on_port_change

 

Reviewed:  https://review.openstack.org/508446
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=530d97141acb63dfe02566bda0a7e78fb058b6b0
Submitter: Zuul
Branch:    master

commit 530d97141acb63dfe02566bda0a7e78fb058b6b0
Author: jufeng <jesse@xxxxxxxxxxxx>
Date:   Fri Sep 29 16:38:24 2017 +0800

    Fix unnecessary security_groups_member_updated notification
    
    notify_sg_on_port_change will cause unnecessary notification to
    neutron-l2-agents when port update, for example like port's name
    updating will also notify.
    
    notify_sg_on_port_change will only be needed when port's
    Security Group update or port IP change.
    
    Change-Id: I5439adf2c4b7dcf832241201fd949f6930e65fdf
    Closes-Bug: #1720322


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1720322

Title:
  Unnecessary notification when notify_sg_on_port_change

Status in neutron:
  Fix Released

Bug description:
  In this patch: https://review.openstack.org/#/c/435601
  It added notify_sg_on_port_change when any port attributes update. This will cause unnecessary notification to neutron-l2-agents when port update, for example like port's name update.
  notify_sg_on_port_change will only needed when port's Security Group update or port IP change, and this has done in codes: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L1405

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1720322/+subscriptions


References