← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1738983] Re: Dynamic routing: invalid exception inputs leads to test exceptions

 

Reviewed:  https://review.openstack.org/550000
Committed: https://git.openstack.org/cgit/openstack/neutron-dynamic-routing/commit/?id=39d9d0de9e13077431243f898022c1aa11b8ef64
Submitter: Zuul
Branch:    master

commit 39d9d0de9e13077431243f898022c1aa11b8ef64
Author: YAMAMOTO Takashi <yamamoto@xxxxxxxxxxxx>
Date:   Tue Mar 6 19:14:38 2018 +0900

    Fix TypeError for BgpSpeakerRescheduleError
    
    Inherit Conflicts to be consistent with RouterReschedulingFailed.
    
    Closes-Bug: #1738983
    Change-Id: If2d6151c161d1b0848ecb28bdb823676249e1221


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1738983

Title:
  Dynamic routing: invalid exception inputs leads to test exceptions

Status in neutron:
  Fix Released

Bug description:
  Unit tests have exceptions:

  Exception encountered during bgp_speaker rescheduling.
  Traceback (most recent call last):
    File "/home/gkotton/neutron-dynamic-routing/.tox/py27/src/neutron/neutron/db/agentschedulers_db.py", line 159, in reschedule_resources_from_down_agents
      reschedule_resource(context, binding_resource_id)
    File "neutron_dynamic_routing/db/bgp_dragentscheduler_db.py", line 174, in reschedule_bgp_speaker
      failure_reason="no eligible dr agent found")
  TypeError: __init__() got an unexpected keyword argument 'failure_reason'
  BgpDrAgent 84dfa040-c1d4-40b1-8a16-0502ffccbb5b is down

  The tests pass but this will lead to extra failures in the real worl

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1738983/+subscriptions


References