yahoo-eng-team team mailing list archive

[OpenStack Infra <1750353@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/545799
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d5f27524819bc95530d0d5856782546fd02d65f8
Submitter: Zuul
Branch:    master

commit d5f27524819bc95530d0d5856782546fd02d65f8
Author: Lujin <luo.lujin@xxxxxxxxxxxxxx>
Date:   Mon Feb 19 20:06:07 2018 +0900

    Ensure _get_changed_synthetic_fields() return updatable fields
    
    Currently _get_changed_synthetic_fields() does not guarantee
    returned fields to be updatable. This patch adds this guarantee.
    
    Change-Id: I123ae390bec489a931180a2e33f4bf7b1d51edb2
    Closes-Bug: #1750353


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1750353

Title:
  _get_changed_synthetic_fields() does not guarantee returned fields to
  be updatable

Status in neutron:
  Fix Released

Bug description:
  While revising [1], I discovered an issue of
  _get_changed_synthetic_fields(): it does not guarantee returned fields
  to be updatable.

  How to reproduce:
   Set a breakpoint in [2] and then run neutron.tests.unit.objects.test_ports.DistributedPortBindingIfaceObjTestCase.test_update_updates_from_db_object, the returned fields are
  -> return fields
  (Pdb) fields
  {'host': u'c2753a12ec', 'port_id': 'ae5700cd-f872-4694-bf36-92b919b0d3bf'}
  where 'host' and 'port_id' are not updatable.

  [1] https://review.openstack.org/#/c/544206/
  [2] https://github.com/openstack/neutron/blob/master/neutron/objects/base.py#L696

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1750353/+subscriptions