← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1746754] Re: network detail tab should be pluggable

 

Reviewed:  https://review.openstack.org/540097
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a987c039cfa7943afd5bb9d1aef50c30b32ad8f4
Submitter: Zuul
Branch:    master

commit a987c039cfa7943afd5bb9d1aef50c30b32ad8f4
Author: Akihiro Motoki <amotoki@xxxxxxxxx>
Date:   Fri Feb 2 02:33:23 2018 +0900

    TabGroup: Make tabs pluggable via horizon plugin config
    
    This commit enhances django tab implementation to allow horizon plugins
    to add tabs to a tab group in other repository like the main horizon repo.
    New setting "EXTRA_TABS" is introduced to the horizon plugin 'enabled' file.
    To this aim, the tab group class looks up HORIZON_CONFIG['extra_tabs']
    with its class full name and loads them as extra tabs if any.
    HORIZON_CONFIG['extra_tabs'] are populated via horizon plugin settings.
    
    This commit moves update_settings in openstack_dashboard.test.helpers
    to horizon as I would like to use it in a new horizon unit test.
    
    blueprint horizon-plugin-tab-for-info-and-quotas
    Closes-Bug: #1746754
    Change-Id: Ice2469a90553754929826d14d20b4719bd1f62d3


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1746754

Title:
  network detail tab should be pluggable

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Some horizon plugin would like to add a tab to the network detail page.
  For example, Project networking-bgpvpn would like to add a tab about network-association to the network detail tab. [1]

  This can be pluggable via python entrypoints and the similar approach
  adopted in blueprint  horizon-plugin-tab-for-info-and-quotas [2] can
  be applied.

  [1] http://eavesdrop.openstack.org/irclogs/%23openstack-horizon/%23openstack-horizon.2018-02-01.log.html#t2018-02-01T15:18:30
  [2] https://blueprints.launchpad.net/horizon/+spec/horizon-plugin-tab-for-info-and-quotas

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1746754/+subscriptions


References