yahoo-eng-team team mailing list archive

[OpenStack Infra <1753833@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/550967
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8da6831e6375d013f0235a542b6b91580a43f61f
Submitter: Zuul
Branch:    master

commit 8da6831e6375d013f0235a542b6b91580a43f61f
Author: Surya Seetharaman <suryaseetharaman.9@xxxxxxxxx>
Date:   Thu Mar 8 19:06:00 2018 +0100

    Make archive_deleted_rows handle a missing CONF.api_database.connection
    
    This change https://review.openstack.org/#/c/515034/ (added in queens)
    makes the archive_deleted_rows CLI remove instance mappings and request
    specs from the API database if there are instances archived from the
    main nova/cell database. However for this to work, the api database
    connection should be set in the config file. So in the case that the
    API database is not configured in the config file being used to run the
    CLI, we should gracefully handle the condition and and stop archiving thus
    prompting the user to set the api_db config and try the archival operation
    again. This patch fixes the graceful handling.
    
    Change-Id: I0c7b802a453aa423c7273ab724ce78eac0cfed4c
    Closes-Bug: #1753833


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1753833

Title:
  archive_deleted_rows --until-complete stops if api database is not
  configured

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) queens series:
  In Progress

Bug description:
  This change https://review.openstack.org/#/c/515034/ (added in queens)
  makes the archive_deleted_rows CLI remove instance mappings and
  request specs from the API database if there are instances archived
  from the main nova/cell database.

  However, with 'superconductor' mode configurations where the cell
  shouldn't be configured to reach the API database, this will fail, as
  seen here:

  http://logs.openstack.org/71/550171/4/check/nova-next/4986796/logs
  /devstack-gate-post_test_hook.txt.gz#_2018-03-06_20_44_21_017

  So in the case that the API database isn't configured in the nova.conf
  being used to run the CLI, we should gracefully handle the condition
  and continue archiving.

  I think we could either do this by handling the CantStartEngineError
  from oslo.db or just check to see if CONF.api_database.connection is
  set before attempting to hit records in the API DB.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1753833/+subscriptions